From 28cf06e509e1601ec74fd0a92410cc097144be8c Mon Sep 17 00:00:00 2001 From: Wylie Conlon Date: Wed, 9 Jun 2021 15:33:08 -0400 Subject: [PATCH] More review comments --- .../dimension_panel/dimension_editor.tsx | 5 +++-- .../operations/definitions/formula/editor/formula_editor.tsx | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx index 821129b84543a..ed20c8c3d39e4 100644 --- a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx +++ b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx @@ -349,13 +349,14 @@ export function DimensionEditor(props: DimensionEditorProps) {

{i18n.translate('xpack.lens.indexPattern.formulaWarningText', { - defaultMessage: 'Picking a quick function will erase your formula.', + defaultMessage: 'To overwrite your formula, select a quick function', })}

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx index dbed58e474833..312ceb116dced 100644 --- a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx +++ b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx @@ -734,6 +734,7 @@ export function FormulaEditor({ className="lnsFormula__editorError" iconType="alert" size="xs" + flush="right" onClick={() => { setIsWarningOpen(!isWarningOpen); }}