create management service registry and adapt existing code

src/legacy/core_plugins/kibana/public/management/saved_object_registry.ts

@@ -17,64 +17,45 @@
  * under the License.
  */
 
-import _ from 'lodash';
 import { i18n } from '@kbn/i18n';
-import { npStart } from 'ui/new_platform';
-import { SavedObjectLoader } from '../../../../../plugins/saved_objects/public';
+import { npSetup, npStart } from 'ui/new_platform';
 import { createSavedDashboardLoader } from '../dashboard';
 import { TypesService, createSavedVisLoader } from '../../../visualizations/public';
 import { createSavedSearchesLoader } from '../../../../../plugins/discover/public';
 
-/**
- * This registry is used for the editing mode of Saved Searches, Visualizations,
- * Dashboard and Time Lion saved objects.
- */
-interface SavedObjectRegistryEntry {
-  id: string;
-  service: SavedObjectLoader;
-  title: string;
+const registry = npSetup.plugins.savedObjectsManagement?.serviceRegistry;
+
+// TODO: should no longer be needed after migration
+export const savedObjectManagementRegistry = registry!;
+
+if (registry) {
+  const services = {
+    savedObjectsClient: npStart.core.savedObjects.client,
+    indexPatterns: npStart.plugins.data.indexPatterns,
+    chrome: npStart.core.chrome,
+    overlays: npStart.core.overlays,
+  };
+
+  savedObjectManagementRegistry.register({
+    id: 'savedVisualizations',
+    service: createSavedVisLoader({
+      ...services,
+      ...{ visualizationTypes: new TypesService().start() },
+    }),
+    title: 'visualizations',
+  });
+
+  savedObjectManagementRegistry.register({
+    id: 'savedDashboards',
+    service: createSavedDashboardLoader(services),
+    title: i18n.translate('kbn.dashboard.savedDashboardsTitle', {
+      defaultMessage: 'dashboards',
+    }),
+  });
+
+  savedObjectManagementRegistry.register({
+    id: 'savedSearches',
+    service: createSavedSearchesLoader(services),
+    title: 'searches',
+  });
 }
-
-const registry: SavedObjectRegistryEntry[] = [];
-
-export const savedObjectManagementRegistry = {
-  register: (service: SavedObjectRegistryEntry) => {
-    registry.push(service);
-  },
-  all: () => {
-    return registry;
-  },
-  get: (id: string) => {
-    return _.find(registry, { id });
-  },
-};
-
-const services = {
-  savedObjectsClient: npStart.core.savedObjects.client,
-  indexPatterns: npStart.plugins.data.indexPatterns,
-  chrome: npStart.core.chrome,
-  overlays: npStart.core.overlays,
-};
-
-savedObjectManagementRegistry.register({
-  id: 'savedVisualizations',
-  service: createSavedVisLoader({
-    ...services,
-    ...{ visualizationTypes: new TypesService().start() },
-  }),
-  title: 'visualizations',
-});
-
-savedObjectManagementRegistry.register({
-  id: 'savedDashboards',
-  service: createSavedDashboardLoader(services),
-  title: i18n.translate('kbn.dashboard.savedDashboardsTitle', {
-    defaultMessage: 'dashboards',
-  }),
-});
-
-savedObjectManagementRegistry.register({
-  id: 'savedSearches',
-  service: createSavedSearchesLoader(services),
-  title: 'searches',
-});

src/legacy/ui/public/new_platform/new_platform.ts

@@ -52,6 +52,7 @@ import {
   NavigationPublicPluginStart,
 } from '../../../../plugins/navigation/public';
 import { VisTypeVegaSetup } from '../../../../plugins/vis_type_vega/public';
+import { SavedObjectsManagementPluginSetup } from '../../../../plugins/so_management/public';
 
 export interface PluginsSetup {
   bfetch: BfetchPublicSetup;
@@ -71,6 +72,7 @@ export interface PluginsSetup {
   management: ManagementSetup;
   visTypeVega: VisTypeVegaSetup;
   telemetry?: TelemetryPluginSetup;
+  savedObjectsManagement?: SavedObjectsManagementPluginSetup;
 }
 
 export interface PluginsStart {

src/plugins/so_management/public/index.ts

@@ -20,6 +20,9 @@
 import { PluginInitializerContext } from 'kibana/public';
 import { SavedObjectsManagementPlugin } from './plugin';
 
+export { SavedObjectsManagementPluginSetup } from './types';
+export { ISavedObjectsManagementRegistry } from './management_registry';
+
 export function plugin(initializerContext: PluginInitializerContext) {
   return new SavedObjectsManagementPlugin();
 }

src/plugins/so_management/public/management/index.tsx

@@ -27,19 +27,21 @@ import { CoreSetup, CoreStart } from 'src/core/public';
 import { ManagementSetup } from '../../../management/public';
 import { DataPublicPluginStart } from '../../../data/public';
 import { StartDependencies } from '../plugin';
+import { ISavedObjectsManagementRegistry } from '../management_registry';
 import { SavedObjectsTable } from './saved_objects_table';
 import { getAllowedTypes } from './lib';
 
 interface RegisterOptions {
   core: CoreSetup<StartDependencies>;
   sections: ManagementSetup['sections'];
+  serviceRegistry: ISavedObjectsManagementRegistry;
 }
 
 const title = i18n.translate('kbn.management.objects.savedObjectsSectionLabel', {
   defaultMessage: 'Saved Objects XXX',
 });
 
-export const registerManagementSection = ({ core, sections }: RegisterOptions) => {
+export const registerManagementSection = ({ core, sections, serviceRegistry }: RegisterOptions) => {
   const kibanaSection = sections.getSection('kibana');
   if (!kibanaSection) {
     throw new Error('`kibana` management section not found.');
@@ -60,6 +62,7 @@ export const registerManagementSection = ({ core, sections }: RegisterOptions) =
                 <SavedObjectsTablePage
                   coreStart={coreStart}
                   dataStart={data}
+                  serviceRegistry={serviceRegistry}
                   allowedTypes={allowedTypes}
                 />
               </Route>
@@ -80,16 +83,19 @@ const SavedObjectsTablePage = ({
   coreStart,
   dataStart,
   allowedTypes,
+  serviceRegistry,
 }: {
   coreStart: CoreStart;
   dataStart: DataPublicPluginStart;
   allowedTypes: string[];
+  serviceRegistry: ISavedObjectsManagementRegistry;
 }) => {
   const capabilities = coreStart.application.capabilities;
   const itemsPerPage = coreStart.uiSettings.get<number>('savedObjects:perPage', 50);
   return (
     <SavedObjectsTable
       allowedTypes={allowedTypes}
+      serviceRegistry={serviceRegistry}
       savedObjectsClient={coreStart.savedObjects.client}
       indexPatterns={dataStart.indexPatterns}
       http={coreStart.http}

src/plugins/so_management/public/management/saved_objects_table.tsx

@@ -45,6 +45,7 @@ import {
   EuiSwitch,
   EuiToolTip,
   EuiPageContent,
+  // @ts-ignore
   Query,
 } from '@elastic/eui';
 import {
@@ -57,6 +58,7 @@ import {
 } from 'src/core/public';
 import { IndexPatternsContract } from '../../../data/public';
 import { SavedObjectWithMetadata } from '../types';
+import { ISavedObjectsManagementRegistry } from '../management_registry';
 import {
   parseQuery,
   getSavedObjectCounts,
@@ -72,6 +74,7 @@ import { Table, Header, Relationships } from './components';
 
 interface SavedObjectsTableProps {
   allowedTypes: string[];
+  serviceRegistry: ISavedObjectsManagementRegistry;
   savedObjectsClient: SavedObjectsClientContract;
   indexPatterns: IndexPatternsContract;
   http: HttpStart;

src/plugins/so_management/public/management_registry.ts

@@ -0,0 +1,47 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { SavedObjectLoader } from '../../saved_objects/public';
+
+export interface SavedObjectsManagementRegistryEntry {
+  id: string;
+  service: SavedObjectLoader;
+  title: string;
+}
+
+export type ISavedObjectsManagementRegistry = PublicMethodsOf<SavedObjectsManagementRegistry>;
+
+export class SavedObjectsManagementRegistry {
+  private readonly registry = new Map<string, SavedObjectsManagementRegistryEntry>();
+
+  public register(service: SavedObjectsManagementRegistryEntry) {
+    if (this.registry.has(service.id)) {
+      throw new Error('');
+    }
+    this.registry.set(service.id, service);
+  }
+
+  public all(): SavedObjectsManagementRegistryEntry[] {
+    return Object.values(this.registry);
+  }
+
+  public get(id: string): SavedObjectsManagementRegistryEntry | undefined {
+    return this.registry.get(id);
+  }
+}

src/plugins/so_management/public/plugin.ts

@@ -21,6 +21,8 @@ import { CoreSetup, CoreStart, Plugin } from 'src/core/public';
 import { ManagementSetup } from '../../management/public';
 import { DataPublicPluginStart } from '../../data/public';
 import { registerManagementSection } from './management';
+import { SavedObjectsManagementPluginSetup } from './types';
+import { SavedObjectsManagementRegistry } from './management_registry';
 
 export interface SetupDependencies {
   management: ManagementSetup;
@@ -31,14 +33,22 @@ export interface StartDependencies {
 }
 
 export class SavedObjectsManagementPlugin
-  implements Plugin<{}, {}, SetupDependencies, StartDependencies> {
-  public setup(core: CoreSetup<StartDependencies>, { management }: SetupDependencies) {
+  implements Plugin<SavedObjectsManagementPluginSetup, {}, SetupDependencies, StartDependencies> {
+  private readonly serviceRegistry = new SavedObjectsManagementRegistry();
+
+  public setup(
+    core: CoreSetup<StartDependencies>,
+    { management }: SetupDependencies
+  ): SavedObjectsManagementPluginSetup {
     registerManagementSection({
       core,
+      serviceRegistry: this.serviceRegistry,
       sections: management.sections,
     });
 
-    return {};
+    return {
+      serviceRegistry: this.serviceRegistry,
+    };
   }
 
   public start(core: CoreStart) {

src/plugins/so_management/public/types.ts

@@ -18,6 +18,11 @@
  */
 
 import { SavedObject } from 'src/core/public';
+import { ISavedObjectsManagementRegistry } from './management_registry';
+
+export interface SavedObjectsManagementPluginSetup {
+  serviceRegistry: ISavedObjectsManagementRegistry;
+}
 
 export type SavedObjectWithMetadata<T = unknown> = SavedObject<T> & {
   meta: {

src/plugins/so_management/server/services/management.mock.ts

@@ -22,13 +22,18 @@ import { SavedObjectsManagement } from './management';
 type Management = PublicMethodsOf<SavedObjectsManagement>;
 const createManagementMock = () => {
   const mocked: jest.Mocked<Management> = {
-    isImportAndExportable: jest.fn().mockReturnValue(true),
+    getImportableAndExportableTypes: jest.fn(),
+    isImportAndExportable: jest.fn(),
     getDefaultSearchField: jest.fn(),
     getIcon: jest.fn(),
     getTitle: jest.fn(),
     getEditUrl: jest.fn(),
     getInAppUrl: jest.fn(),
   };
+
+  mocked.getImportableAndExportableTypes.mockReturnValue([]);
+  mocked.isImportAndExportable.mockReturnValue(true);
+
   return mocked;
 };