From 585c367e13522a4376ee9bc1fd42a2028f0b5da3 Mon Sep 17 00:00:00 2001 From: Tyler Smalley Date: Wed, 15 Jul 2020 13:56:55 -0700 Subject: [PATCH] [test] Reverts skipped tests caused by null API name (#71632) (#71930) * Revert "[test] Skips test preventing promotion of ES snapshot #71582" This reverts commit 683fb42df73e5ca92be299f8112d29c0a4037bab. * Revert "[test] Skips test preventing promotion of ES snapshot #71555" This reverts commit 8555ecbcf40f6041bd59ea628e16cd85c2bee408. * Revert "[test] Skips Alerting test preventing ES snapshot promotion" This reverts commit b217cb3f969f6cd4fbe6faebb2c4045196c69ffa. * Revert "[test] Skips test preventing promotion of ES snapshot" This reverts commit 0194f8c149ba2ce04341ebae42ee394d9cab1e1b. * Revert "[skip test] Skips Alerting API test due to failing ES promotion" This reverts commit 439f2dd04704b74a881d2a705803b8c64f6513d2. --- .../security_and_spaces/tests/alerting/alerts.ts | 3 +-- .../security_and_spaces/tests/alerting/update.ts | 3 +-- .../security_and_spaces/tests/create_rules.ts | 3 +-- .../functional_with_es_ssl/apps/triggers_actions_ui/details.ts | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts b/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts index dce809f0b7be9..ab58a205f9d47 100644 --- a/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts +++ b/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts @@ -26,8 +26,7 @@ export default function alertTests({ getService }: FtrProviderContext) { const esTestIndexTool = new ESTestIndexTool(es, retry); const taskManagerUtils = new TaskManagerUtils(es, retry); - // Failing ES promotion: https://github.com/elastic/kibana/issues/71582 - describe.skip('alerts', () => { + describe('alerts', () => { const authorizationIndex = '.kibana-test-authorization'; const objectRemover = new ObjectRemover(supertest); diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/update.ts b/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/update.ts index 37c0116396b1c..2bcc035beb7a9 100644 --- a/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/update.ts +++ b/x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/update.ts @@ -29,8 +29,7 @@ export default function createUpdateTests({ getService }: FtrProviderContext) { .then((response: SupertestResponse) => response.body); } - // Failing ES promotion: https://github.com/elastic/kibana/issues/71558 - describe.skip('update', () => { + describe('update', () => { const objectRemover = new ObjectRemover(supertest); after(() => objectRemover.removeAll()); diff --git a/x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts b/x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts index 73d39b600cf11..c763be1c2c3ec 100644 --- a/x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts +++ b/x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts @@ -31,8 +31,7 @@ export default ({ getService }: FtrProviderContext) => { const supertest = getService('supertest'); const es = getService('es'); - // Preventing ES promotion: https://github.com/elastic/kibana/issues/71555 - describe.skip('create_rules', () => { + describe('create_rules', () => { describe('validation errors', () => { it('should give an error that the index must exist first if it does not exist before creating a rule', async () => { const { body } = await supertest diff --git a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts index 4c33a709d9bf9..d86d272c1da8c 100644 --- a/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts +++ b/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/details.ts @@ -19,8 +19,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { const retry = getService('retry'); const find = getService('find'); - // Failing ES Promotion: https://github.com/elastic/kibana/issues/71559 - describe.skip('Alert Details', function () { + describe('Alert Details', function () { describe('Header', function () { const testRunUuid = uuid.v4(); before(async () => {