From a0dc26f0958227435f19a2a01290f3c0454c6c49 Mon Sep 17 00:00:00 2001 From: Ben Skelker <54019610+benskelker@users.noreply.github.com> Date: Thu, 16 Jul 2020 09:42:20 +0300 Subject: [PATCH] [Security Solution]Fix in-app links and popup window text (#71403) * updates in-app links * updates links from prebuilt ML jobs * updates kibana help window text and link * removes problematic terminolgy from prebuilt job descriptions * Revert "removes problematic terminolgy from prebuilt job descriptions" This reverts commit aaa7e2a4ca0ac911622de140570fecd3b6b7e154, as it will be done via the rules repo. * Revert "updates links from prebuilt ML jobs" This reverts commit to update links from prebuilt jobs, will be done via the rules repo. * recommits the link correction after revert * changes help window app name to Security --- src/core/public/doc_links/doc_links_service.ts | 4 ++-- .../public/cases/pages/saved_object_no_permissions.tsx | 2 +- .../public/common/components/help_menu/index.tsx | 4 ++-- .../public/common/components/ml_popover/ml_popover.tsx | 2 +- .../components/rules/pre_packaged_rules/update_callout.tsx | 2 +- .../detection_engine/detection_engine_no_signal_index.tsx | 2 +- .../detection_engine_user_unauthenticated.tsx | 2 +- .../embeddables/__snapshots__/embedded_map.test.tsx.snap | 2 +- .../public/network/components/embeddables/embedded_map.tsx | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/core/public/doc_links/doc_links_service.ts b/src/core/public/doc_links/doc_links_service.ts index 0662586797164..70b25cb78787a 100644 --- a/src/core/public/doc_links/doc_links_service.ts +++ b/src/core/public/doc_links/doc_links_service.ts @@ -111,8 +111,8 @@ export class DocLinksService { }, kibana: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index.html`, siem: { - guide: `${ELASTIC_WEBSITE_URL}guide/en/siem/guide/${DOC_LINK_VERSION}/index.html`, - gettingStarted: `${ELASTIC_WEBSITE_URL}guide/en/siem/guide/${DOC_LINK_VERSION}/install-siem.html`, + guide: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/index.html`, + gettingStarted: `${ELASTIC_WEBSITE_URL}guide/en/security/${DOC_LINK_VERSION}/install-siem.html`, }, query: { luceneQuerySyntax: `${ELASTICSEARCH_DOCS}query-dsl-query-string-query.html#query-string-syntax`, diff --git a/x-pack/plugins/security_solution/public/cases/pages/saved_object_no_permissions.tsx b/x-pack/plugins/security_solution/public/cases/pages/saved_object_no_permissions.tsx index a560f697de415..7129aa04bdf69 100644 --- a/x-pack/plugins/security_solution/public/cases/pages/saved_object_no_permissions.tsx +++ b/x-pack/plugins/security_solution/public/cases/pages/saved_object_no_permissions.tsx @@ -17,7 +17,7 @@ export const CaseSavedObjectNoPermissions = React.memo(() => { { useEffect(() => { chrome.setHelpExtension({ appName: i18n.translate('xpack.securitySolution.chrome.help.appName', { - defaultMessage: 'SIEM', + defaultMessage: 'Security', }), links: [ { content: i18n.translate('xpack.securitySolution.chrome.helpMenu.documentation', { - defaultMessage: 'SIEM documentation', + defaultMessage: 'Security documentation', }), href: docLinks.links.siem.guide, iconType: 'documents', diff --git a/x-pack/plugins/security_solution/public/common/components/ml_popover/ml_popover.tsx b/x-pack/plugins/security_solution/public/common/components/ml_popover/ml_popover.tsx index a34dfb5753d92..0ebf367471848 100644 --- a/x-pack/plugins/security_solution/public/common/components/ml_popover/ml_popover.tsx +++ b/x-pack/plugins/security_solution/public/common/components/ml_popover/ml_popover.tsx @@ -177,7 +177,7 @@ export const MlPopover = React.memo(() => { values={{ mlDocs: ( diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/pre_packaged_rules/update_callout.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/pre_packaged_rules/update_callout.tsx index 3be2b853925f6..4b454a9ed4d4a 100644 --- a/x-pack/plugins/security_solution/public/detections/components/rules/pre_packaged_rules/update_callout.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/rules/pre_packaged_rules/update_callout.tsx @@ -56,7 +56,7 @@ const UpdatePrePackagedRulesCallOutComponent: React.FC {i18n.RELEASE_NOTES_HELP} diff --git a/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine_no_signal_index.tsx b/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine_no_signal_index.tsx index 59267b5d62a26..32ae585aec191 100644 --- a/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine_no_signal_index.tsx +++ b/x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine_no_signal_index.tsx @@ -16,7 +16,7 @@ export const DetectionEngineNoIndex = React.memo(() => { { Map configuration help diff --git a/x-pack/plugins/security_solution/public/network/components/embeddables/embedded_map.tsx b/x-pack/plugins/security_solution/public/network/components/embeddables/embedded_map.tsx index 828e4d3eaaaa0..4d96c213818aa 100644 --- a/x-pack/plugins/security_solution/public/network/components/embeddables/embedded_map.tsx +++ b/x-pack/plugins/security_solution/public/network/components/embeddables/embedded_map.tsx @@ -185,7 +185,7 @@ export const EmbeddedMapComponent = ({ {i18n.EMBEDDABLE_HEADER_HELP}