Skip to content

Commit

Permalink
functional and jest test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomThomson committed Jun 30, 2020
1 parent 3ee8263 commit a34d585
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/plugins/embeddable/public/lib/containers/container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@ export abstract class Container<
return {
type: factory.type,
explicitInput: {
id: embeddableId,
...explicitInput,
id: embeddableId,
} as TEmbeddableInput,
};
}
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/lens/public/app_plugin/app.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ describe('Lens App', () => {
expression: 'kibana 3',
});

expect(args.redirectTo).toHaveBeenCalledWith('aaa', undefined, true);
expect(args.redirectTo).toHaveBeenCalledWith('aaa', undefined, undefined, true, undefined);

inst.setProps({ docId: 'aaa' });

Expand All @@ -556,7 +556,7 @@ describe('Lens App', () => {
expression: 'kibana 3',
});

expect(args.redirectTo).toHaveBeenCalledWith('aaa', undefined, true);
expect(args.redirectTo).toHaveBeenCalledWith('aaa', undefined, undefined, true, undefined);

inst.setProps({ docId: 'aaa' });

Expand Down Expand Up @@ -624,7 +624,7 @@ describe('Lens App', () => {
title: 'hello there',
});

expect(args.redirectTo).toHaveBeenCalledWith('aaa', true, true);
expect(args.redirectTo).toHaveBeenCalledWith('aaa', undefined, true, true, undefined);
});

it('saves app filters and does not save pinned filters', async () => {
Expand Down

0 comments on commit a34d585

Please sign in to comment.