Merge remote-tracking branch 'origin/master' into lens/click-telemetry

docs/developer/core/development-elasticsearch.asciidoc

@@ -3,7 +3,7 @@
 
 Kibana exposes two clients on the server and browser for communicating with elasticsearch.
 There is an 'admin' client which is used for managing Kibana's state, and a 'data' client for all
-other requests.  The clients use the {client-ref}/javascript-api/current/index.html[elasticsearch.js library].
+other requests.  The clients use the {jsclient}/javascript-api/current/index.html[elasticsearch.js library].
 
 [float]
 [[client-server]]

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_top_row.tsx

@@ -24,7 +24,7 @@ import React, { useState, useEffect } from 'react';
 
 import { EuiButton, EuiFlexGroup, EuiFlexItem, EuiLink, EuiSuperDatePicker } from '@elastic/eui';
 // @ts-ignore
-import { EuiSuperUpdateButton } from '@elastic/eui';
+import { EuiSuperUpdateButton, OnRefreshProps } from '@elastic/eui';
 import { FormattedMessage, InjectedIntl, injectI18n } from '@kbn/i18n/react';
 import { Toast } from 'src/core/public';
 import { TimeRange } from 'src/plugins/data/public';
@@ -41,10 +41,12 @@ interface Props {
   query?: Query;
   onSubmit: (payload: { dateRange: TimeRange; query?: Query }) => void;
   onChange: (payload: { dateRange: TimeRange; query?: Query }) => void;
+  onRefresh?: (payload: { dateRange: TimeRange }) => void;
   disableAutoFocus?: boolean;
   screenTitle?: string;
   indexPatterns?: Array<IndexPattern | string>;
   intl: InjectedIntl;
+  isLoading?: boolean;
   prepend?: React.ReactNode;
   showQueryInput?: boolean;
   showDatePicker?: boolean;
@@ -125,6 +127,18 @@ function QueryBarTopRowUI(props: Props) {
     }
   }
 
+  function onRefresh({ start, end }: OnRefreshProps) {
+    const retVal = {
+      dateRange: {
+        from: start,
+        to: end,
+      },
+    };
+    if (props.onRefresh) {
+      props.onRefresh(retVal);
+    }
+  }
+
   function onSubmit({ query, dateRange }: { query?: Query; dateRange: TimeRange }) {
     handleLuceneSyntaxWarning();
 
@@ -175,6 +189,7 @@ function QueryBarTopRowUI(props: Props) {
       <EuiSuperUpdateButton
         needsUpdate={props.isDirty}
         isDisabled={isDateRangeInvalid}
+        isLoading={props.isLoading}
         onClick={onClickSubmitButton}
         data-test-subj="querySubmitButton"
       />
@@ -227,6 +242,7 @@ function QueryBarTopRowUI(props: Props) {
           isPaused={props.isRefreshPaused}
           refreshInterval={props.refreshInterval}
           onTimeChange={onTimeChange}
+          onRefresh={onRefresh}
           onRefreshChange={props.onRefreshChange}
           showUpdateButton={false}
           recentlyUsedRanges={recentlyUsedRanges}

src/legacy/core_plugins/data/public/search/search_bar/components/create_search_bar.tsx

@@ -17,7 +17,8 @@
  * under the License.
  */
 
-import React from 'react';
+import React, { useState, useEffect } from 'react';
+import { Subscription } from 'rxjs';
 import { Filter } from '@kbn/es-query';
 import { CoreStart } from 'src/core/public';
 import { DataPublicPluginStart } from 'src/plugins/data/public';
@@ -64,8 +65,48 @@ export function createSearchBar({
   // App name should come from the core application service.
   // Until it's available, we'll ask the user to provide it for the pre-wired component.
   return (props: StatetfulSearchBarProps) => {
+    const tfRefreshInterval = timefilter.timefilter.getRefreshInterval();
+    const fmFilters = filterManager.getFilters();
+    const [refreshInterval, setRefreshInterval] = useState(tfRefreshInterval.value);
+    const [refreshPaused, setRefreshPaused] = useState(tfRefreshInterval.pause);
+
+    const [filters, setFilters] = useState(fmFilters);
+
+    // We do not really need to keep track of the time
+    // since this is just for initialization
     const timeRange = timefilter.timefilter.getTime();
-    const refreshInterval = timefilter.timefilter.getRefreshInterval();
+
+    useEffect(() => {
+      let isSubscribed = true;
+      const subscriptions = new Subscription();
+      subscriptions.add(
+        timefilter.timefilter.getRefreshIntervalUpdate$().subscribe({
+          next: () => {
+            if (isSubscribed) {
+              const newRefreshInterval = timefilter.timefilter.getRefreshInterval();
+              setRefreshInterval(newRefreshInterval.value);
+              setRefreshPaused(newRefreshInterval.pause);
+            }
+          },
+        })
+      );
+
+      subscriptions.add(
+        filterManager.getUpdates$().subscribe({
+          next: () => {
+            if (isSubscribed) {
+              const newFilters = filterManager.getFilters();
+              setFilters(newFilters);
+            }
+          },
+        })
+      );
+
+      return () => {
+        isSubscribed = false;
+        subscriptions.unsubscribe();
+      };
+    }, []);
 
     return (
       <KibanaContextProvider
@@ -80,9 +121,9 @@ export function createSearchBar({
           timeHistory={timefilter.history}
           dateRangeFrom={timeRange.from}
           dateRangeTo={timeRange.to}
-          refreshInterval={refreshInterval.value}
-          isRefreshPaused={refreshInterval.pause}
-          filters={filterManager.getFilters()}
+          refreshInterval={refreshInterval}
+          isRefreshPaused={refreshPaused}
+          filters={filters}
           onFiltersUpdated={defaultFiltersUpdated(filterManager)}
           onRefreshChange={defaultOnRefreshChange(timefilter)}
           {...props}

src/legacy/core_plugins/data/public/search/search_bar/components/search_bar.tsx

@@ -58,6 +58,7 @@ interface SearchBarInjectedDeps {
 
 export interface SearchBarOwnProps {
   indexPatterns?: IndexPattern[];
+  isLoading?: boolean;
   customSubmitButton?: React.ReactNode;
   screenTitle?: string;
 
@@ -79,6 +80,8 @@ export interface SearchBarOwnProps {
   onSavedQueryUpdated?: (savedQuery: SavedQuery) => void;
   // User has cleared the active query, your app should clear the entire query bar
   onClearSavedQuery?: () => void;
+
+  onRefresh?: (payload: { dateRange: TimeRange }) => void;
 }
 
 export type SearchBarProps = SearchBarOwnProps & SearchBarInjectedDeps;
@@ -377,6 +380,7 @@ class SearchBarUI extends Component<SearchBarProps, State> {
           screenTitle={this.props.screenTitle}
           onSubmit={this.onQueryBarSubmit}
           indexPatterns={this.props.indexPatterns}
+          isLoading={this.props.isLoading}
           prepend={this.props.showFilterBar ? savedQueryManagement : undefined}
           showDatePicker={this.props.showDatePicker}
           dateRangeFrom={this.state.dateRangeFrom}
@@ -385,6 +389,7 @@ class SearchBarUI extends Component<SearchBarProps, State> {
           refreshInterval={this.props.refreshInterval}
           showAutoRefreshOnly={this.props.showAutoRefreshOnly}
           showQueryInput={this.props.showQueryInput}
+          onRefresh={this.props.onRefresh}
           onRefreshChange={this.props.onRefreshChange}
           onChange={this.onQueryBarChange}
           isDirty={this.isDirty()}

src/legacy/core_plugins/data/public/search/search_bar/index.tsx

@@ -23,7 +23,7 @@ import { Query } from '../../query/query_bar';
 
 export * from './components';
 
-type SavedQueryTimeFilter = TimeRange & {
+export type SavedQueryTimeFilter = TimeRange & {
   refreshInterval: RefreshInterval;
 };
 

x-pack/legacy/plugins/canvas/canvas_plugin_src/elements/index.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { applyElementStrings } from '../strings';
+import { applyElementStrings } from '../../i18n/elements';
 import { areaChart } from './area_chart';
 import { bubbleChart } from './bubble_chart';
 import { debug } from './debug';

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/browser/location.ts

@@ -6,7 +6,7 @@
 
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 import { Datatable } from '../../../types';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 const noop = () => {};
 

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/browser/markdown.ts

@@ -8,7 +8,7 @@ import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 // @ts-ignore untyped local
 import { Handlebars } from '../../../common/lib/handlebars';
 import { Datatable, Render, Style } from '../../../types';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 type Context = Datatable | null;
 

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/browser/urlparam.ts

@@ -6,7 +6,7 @@
 
 import { parse } from 'url';
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 interface Arguments {
   param: string;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/__tests__/compare.js

@@ -7,7 +7,7 @@
 import expect from '@kbn/expect';
 import { compare } from '../compare';
 import { functionWrapper } from '../../../../__tests__/helpers/function_wrapper';
-import { getFunctionErrors } from '../../../strings';
+import { getFunctionErrors } from '../../../../i18n';
 
 const errors = getFunctionErrors().compare;
 

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/__tests__/progress.js

@@ -7,7 +7,7 @@
 import expect from '@kbn/expect';
 import { progress } from '../progress';
 import { functionWrapper } from '../../../../__tests__/helpers/function_wrapper';
-import { getFunctionErrors } from '../../../strings';
+import { getFunctionErrors } from '../../../../i18n';
 import { fontStyle } from './fixtures/test_styles';
 
 const errors = getFunctionErrors().progress;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/all.ts

@@ -5,7 +5,7 @@
  */
 
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 interface Arguments {
   condition: boolean[];

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/alterColumn.test.js

@@ -5,7 +5,7 @@
  */
 
 import { functionWrapper } from '../../../__tests__/helpers/function_wrapper';
-import { getFunctionErrors } from '../../strings';
+import { getFunctionErrors } from '../../../i18n';
 import { emptyTable, testTable } from './__tests__/fixtures/test_tables';
 import { alterColumn } from './alterColumn';
 

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/alterColumn.ts

@@ -7,7 +7,7 @@
 import { omit } from 'lodash';
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 import { Datatable, DatatableColumn, DatatableColumnType } from '../../../types';
-import { getFunctionHelp, getFunctionErrors } from '../../strings';
+import { getFunctionHelp, getFunctionErrors } from '../../../i18n';
 
 interface Arguments {
   column: string;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/any.ts

@@ -5,7 +5,7 @@
  */
 
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 interface Arguments {
   condition: boolean[];

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/as.ts

@@ -8,7 +8,7 @@
 import { getType } from '@kbn/interpreter/common';
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 import { Datatable } from '../../../types';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 interface Arguments {
   name: string;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/axisConfig.ts

@@ -7,7 +7,7 @@
 import moment from 'moment';
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 import { Position } from '../../../types';
-import { getFunctionHelp, getFunctionErrors } from '../../strings';
+import { getFunctionHelp, getFunctionErrors } from '../../../i18n';
 
 interface Arguments {
   show: boolean;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/axis_config.test.js

@@ -5,7 +5,7 @@
  */
 
 import { functionWrapper } from '../../../__tests__/helpers/function_wrapper';
-import { getFunctionErrors } from '../../strings';
+import { getFunctionErrors } from '../../../i18n';
 import { testTable } from './__tests__/fixtures/test_tables';
 import { axisConfig } from './axisConfig';
 

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/case.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 interface Arguments {
   when: () => any;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/clear.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 export function clear(): ExpressionFunction<'clear', any, {}, null> {
   const { help } = getFunctionHelp().clear;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/columns.ts

@@ -7,7 +7,7 @@
 import { omit, pick, find } from 'lodash';
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 import { Datatable, DatatableColumn } from '../../../types';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 interface Arguments {
   include: string;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/compare.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp, getFunctionErrors } from '../../strings';
+import { getFunctionHelp, getFunctionErrors } from '../../../i18n';
 
 export enum Operation {
   EQ = 'eq',

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/containerStyle.ts

@@ -5,7 +5,7 @@
  */
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 import { ContainerStyle, Overflow, BackgroundRepeat, BackgroundSize } from '../../../types';
-import { getFunctionHelp, getFunctionErrors } from '../../strings';
+import { getFunctionHelp, getFunctionErrors } from '../../../i18n';
 // @ts-ignore untyped local
 import { isValidUrl } from '../../../common/lib/url';
 

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/container_style.test.js

@@ -6,7 +6,7 @@
 
 import { functionWrapper } from '../../../__tests__/helpers/function_wrapper';
 import { elasticLogo } from '../../lib/elastic_logo';
-import { getFunctionErrors } from '../../strings';
+import { getFunctionErrors } from '../../../i18n';
 import { containerStyle } from './containerStyle';
 
 const errors = getFunctionErrors().containerStyle;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/context.ts

@@ -5,7 +5,7 @@
  */
 
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp } from '../../strings';
+import { getFunctionHelp } from '../../../i18n';
 
 export function context(): ExpressionFunction<'context', any, {}, any> {
   const { help } = getFunctionHelp().context;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/csv.test.js

@@ -5,7 +5,7 @@
  */
 
 import { functionWrapper } from '../../../__tests__/helpers/function_wrapper';
-import { getFunctionErrors } from '../../strings';
+import { getFunctionErrors } from '../../../i18n';
 import { csv } from './csv';
 
 const errors = getFunctionErrors().csv;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/csv.ts

@@ -7,7 +7,7 @@
 import Papa from 'papaparse';
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
 import { Datatable } from '../../../types';
-import { getFunctionHelp, getFunctionErrors } from '../../strings';
+import { getFunctionHelp, getFunctionErrors } from '../../../i18n';
 
 interface Arguments {
   data: string;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/date.test.js

@@ -6,7 +6,7 @@
 
 import sinon from 'sinon';
 import { functionWrapper } from '../../../__tests__/helpers/function_wrapper';
-import { getFunctionErrors } from '../../strings';
+import { getFunctionErrors } from '../../../i18n';
 import { date } from './date';
 
 const errors = getFunctionErrors().date;

x-pack/legacy/plugins/canvas/canvas_plugin_src/functions/common/date.ts

@@ -6,7 +6,7 @@
 
 import moment from 'moment';
 import { ExpressionFunction } from 'src/legacy/core_plugins/interpreter/public';
-import { getFunctionHelp, getFunctionErrors } from '../../strings';
+import { getFunctionHelp, getFunctionErrors } from '../../../i18n';
 
 interface Arguments {
   value: string;