From d2c5132f7423a15f9c2f9cf3e60c95ec50174235 Mon Sep 17 00:00:00 2001 From: christineweng <18648970+christineweng@users.noreply.github.com> Date: Mon, 10 Feb 2025 13:41:07 -0600 Subject: [PATCH] [Security Solutions] Update cell actions copy (#209436) ## Summary This is a part 2 following https://github.com/elastic/kibana/pull/206340 to standardize actions in the alerts kpi visualizations. This PR updates the following copies: - Changed `Filter In` to `Filter for`: to stay consistent with Lens and Discover image - Updated letter cases by following copy guidelines - `Filter Out` -> `Filter out` - `Copy to Clipboard` -> `Copy to clipboard` - `Investigate in timeline` -> `Investigate in Timeline` - `Add to timeline` -> `Add to Timeline` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --- .../copy_to_clipboard.test.ts | 2 +- .../copy_to_clipboard/copy_to_clipboard.ts | 2 +- .../src/actions/filter/filter_in.test.ts | 2 +- .../src/actions/filter/filter_in.ts | 2 +- .../src/actions/filter/filter_out.test.ts | 2 +- .../src/actions/filter/filter_out.ts | 2 +- .../translations/translations/fr-FR.json | 1 - .../translations/translations/ja-JP.json | 1 - .../translations/translations/zh-CN.json | 1 - .../osquery/cypress/tasks/live_query.ts | 2 +- .../actions/add_to_timeline.test.tsx | 2 +- .../actions/filter_for_value.tsx | 2 +- .../actions/filter_out_value.tsx | 2 +- .../hover_actions/actions/translations.tsx | 6 +++--- .../cell_action/add_to_timeline.test.ts | 2 +- .../investigate_in_new_timeline.test.ts | 2 +- .../app/actions/add_to_timeline/constants.ts | 10 +++++----- .../discover/add_to_timeline.test.ts | 2 +- .../lens/add_to_timeline.test.ts | 2 +- .../cell_action/copy_to_clipboard.test.ts | 2 +- .../actions/copy_to_clipboard/constants.ts | 2 +- .../discover/copy_to_clipboard.test.ts | 2 +- .../lens/copy_to_clipboard.test.ts | 2 +- .../filter/cell_action/filter_in.test.ts | 2 +- .../filter/cell_action/filter_out.test.ts | 2 +- .../actions/filter/discover/filter_in.test.ts | 2 +- .../filter/discover/filter_out.test.ts | 2 +- .../query_bar/components/filter_in.tsx | 20 +++++++++---------- .../query_bar/components/translations.ts | 6 +++--- .../investigations/alerts/alerts_charts.cy.ts | 2 +- 30 files changed, 44 insertions(+), 47 deletions(-) diff --git a/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.test.ts b/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.test.ts index 04893d7d8c8c0..cd51a4a229acb 100644 --- a/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.test.ts +++ b/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.test.ts @@ -39,7 +39,7 @@ describe('Default createCopyToClipboardActionFactory', () => { }); it('should return display name', () => { - expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to Clipboard'); + expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to clipboard'); }); it('should return icon type', () => { diff --git a/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.ts b/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.ts index 90e93923fa360..8902a46683e60 100644 --- a/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.ts +++ b/src/platform/packages/shared/kbn-cell-actions/src/actions/copy_to_clipboard/copy_to_clipboard.ts @@ -24,7 +24,7 @@ import { ACTION_INCOMPATIBLE_VALUE_WARNING } from '../translations'; const ICON = 'copyClipboard'; const COPY_TO_CLIPBOARD = i18n.translate('cellActions.actions.copyToClipboard.displayName', { - defaultMessage: 'Copy to Clipboard', + defaultMessage: 'Copy to clipboard', }); const COPY_TO_CLIPBOARD_SUCCESS = i18n.translate( 'cellActions.actions.copyToClipboard.successMessage', diff --git a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.test.ts b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.test.ts index 2fc51ea4499f3..12aa51460fe8b 100644 --- a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.test.ts +++ b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.test.ts @@ -47,7 +47,7 @@ describe('createFilterInActionFactory', () => { }); it('should return display name', () => { - expect(filterInAction.getDisplayName(context)).toEqual('Filter In'); + expect(filterInAction.getDisplayName(context)).toEqual('Filter for'); }); it('should return icon type', () => { diff --git a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.ts b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.ts index af260ad9f54e7..2947b755ee15f 100644 --- a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.ts +++ b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_in.ts @@ -25,7 +25,7 @@ import type { DefaultActionsSupportedValue } from '../types'; const ICON = 'plusInCircle'; const FILTER_IN = i18n.translate('cellActions.actions.filterIn', { - defaultMessage: 'Filter In', + defaultMessage: 'Filter for', }); export const createFilterInActionFactory = createCellActionFactory( diff --git a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.test.ts b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.test.ts index 38b5196521c40..9490f42f6c38f 100644 --- a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.test.ts +++ b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.test.ts @@ -47,7 +47,7 @@ describe('createFilterOutAction', () => { }); it('should return display name', () => { - expect(filterOutAction.getDisplayName(context)).toEqual('Filter Out'); + expect(filterOutAction.getDisplayName(context)).toEqual('Filter out'); }); it('should return icon type', () => { diff --git a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.ts b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.ts index b5228402ec7f4..2619f27af9a39 100644 --- a/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.ts +++ b/src/platform/packages/shared/kbn-cell-actions/src/actions/filter/filter_out.ts @@ -25,7 +25,7 @@ import type { DefaultActionsSupportedValue } from '../types'; const ICON = 'minusInCircle'; const FILTER_OUT = i18n.translate('cellActions.actions.filterOut', { - defaultMessage: 'Filter Out', + defaultMessage: 'Filter out', }); export const createFilterOutActionFactory = createCellActionFactory( diff --git a/x-pack/platform/plugins/private/translations/translations/fr-FR.json b/x-pack/platform/plugins/private/translations/translations/fr-FR.json index a56d890e2e370..609880473687c 100644 --- a/x-pack/platform/plugins/private/translations/translations/fr-FR.json +++ b/x-pack/platform/plugins/private/translations/translations/fr-FR.json @@ -44134,7 +44134,6 @@ "xpack.threatIntelligence.paywall.title": "Toujours plus avec Security !", "xpack.threatIntelligence.paywall.trial": "Démarrer un essai gratuit", "xpack.threatIntelligence.paywall.upgrade": "Mettre à niveau", - "xpack.threatIntelligence.queryBar.filterIn": "Inclure", "xpack.threatIntelligence.queryBar.filterOut": "Exclure", "xpack.threatIntelligence.timeline.addToTimeline": "Ajouter à la chronologie", "xpack.threatIntelligence.timeline.investigateInTimelineButtonIcon": "Investiguer dans la chronologie", diff --git a/x-pack/platform/plugins/private/translations/translations/ja-JP.json b/x-pack/platform/plugins/private/translations/translations/ja-JP.json index 00f39bdadfd32..3e469ce3e542b 100644 --- a/x-pack/platform/plugins/private/translations/translations/ja-JP.json +++ b/x-pack/platform/plugins/private/translations/translations/ja-JP.json @@ -43988,7 +43988,6 @@ "xpack.threatIntelligence.paywall.title": "Securityではさまざまなことが可能です！", "xpack.threatIntelligence.paywall.trial": "無料トライアルをはじめる", "xpack.threatIntelligence.paywall.upgrade": "アップグレード", - "xpack.threatIntelligence.queryBar.filterIn": "フィルタリング", "xpack.threatIntelligence.queryBar.filterOut": "除外", "xpack.threatIntelligence.timeline.addToTimeline": "タイムラインに追加", "xpack.threatIntelligence.timeline.investigateInTimelineButtonIcon": "タイムラインで調査", diff --git a/x-pack/platform/plugins/private/translations/translations/zh-CN.json b/x-pack/platform/plugins/private/translations/translations/zh-CN.json index 4b5f3693e121b..b24371ddfd6b1 100644 --- a/x-pack/platform/plugins/private/translations/translations/zh-CN.json +++ b/x-pack/platform/plugins/private/translations/translations/zh-CN.json @@ -43333,7 +43333,6 @@ "xpack.threatIntelligence.paywall.title": "Security 让您事半功倍！", "xpack.threatIntelligence.paywall.trial": "开始免费试用", "xpack.threatIntelligence.paywall.upgrade": "升级", - "xpack.threatIntelligence.queryBar.filterIn": "筛选", "xpack.threatIntelligence.queryBar.filterOut": "筛除", "xpack.threatIntelligence.timeline.addToTimeline": "添加到时间线", "xpack.threatIntelligence.timeline.investigateInTimelineButtonIcon": "在时间线中调查", diff --git a/x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts b/x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts index 910427272c5ff..c6836c50c7b27 100644 --- a/x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts +++ b/x-pack/platform/plugins/shared/osquery/cypress/tasks/live_query.ts @@ -162,7 +162,7 @@ export const checkActionItemsInResults = ({ cy.contains('View in Discover').should(discover ? 'exist' : 'not.exist'); cy.contains('View in Lens').should(lens ? 'exist' : 'not.exist'); cy.contains('Add to Case').should(cases ? 'exist' : 'not.exist'); - cy.contains('Add to timeline investigation').should(timeline ? 'exist' : 'not.exist'); + cy.contains('Add to Timeline investigation').should(timeline ? 'exist' : 'not.exist'); }; export const takeOsqueryActionWithParams = () => { diff --git a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/add_to_timeline.test.tsx b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/add_to_timeline.test.tsx index 32c502271e618..741b76d877659 100644 --- a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/add_to_timeline.test.tsx +++ b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/add_to_timeline.test.tsx @@ -437,7 +437,7 @@ describe('add to timeline', () => { children: i18n.ADDED_TO_TIMELINE_OR_TEMPLATE_MESSAGE(providerA.name, true), }; const wrapper = render(); - expect(wrapper.container.textContent).toBe('Added a to timeline'); + expect(wrapper.container.textContent).toBe('Added a to Timeline'); }); test('Add success is called with "template" if timeline type is template', () => { diff --git a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_for_value.tsx b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_for_value.tsx index 9b5eaa3c1da02..7528a8d436fbb 100644 --- a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_for_value.tsx +++ b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_for_value.tsx @@ -15,7 +15,7 @@ import { createFilter, getAdditionalScreenReaderOnlyContext } from '../utils'; import { HoverActionComponentProps, FilterValueFnArgs } from './types'; export const FILTER_FOR_VALUE = i18n.translate('xpack.timelines.hoverActions.filterIn', { - defaultMessage: 'Filter In', + defaultMessage: 'Filter for', }); export const FILTER_FOR_VALUE_KEYBOARD_SHORTCUT = 'f'; diff --git a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_out_value.tsx b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_out_value.tsx index 013f6862bab77..5e0074d761f83 100644 --- a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_out_value.tsx +++ b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/filter_out_value.tsx @@ -15,7 +15,7 @@ import { createFilter, getAdditionalScreenReaderOnlyContext } from '../utils'; import { HoverActionComponentProps, FilterValueFnArgs } from './types'; export const FILTER_OUT_VALUE = i18n.translate('xpack.timelines.hoverActions.filterOut', { - defaultMessage: 'Filter Out', + defaultMessage: 'Filter out', }); export const FILTER_OUT_VALUE_KEYBOARD_SHORTCUT = 'o'; diff --git a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/translations.tsx b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/translations.tsx index 864967ce51e03..7ec4b1778abae 100644 --- a/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/translations.tsx +++ b/x-pack/platform/plugins/shared/timelines/public/components/hover_actions/actions/translations.tsx @@ -8,19 +8,19 @@ import { i18n } from '@kbn/i18n'; export const ADD_TO_TIMELINE = i18n.translate('xpack.timelines.hoverActions.addToTimeline', { - defaultMessage: 'Add to timeline investigation', + defaultMessage: 'Add to Timeline investigation', }); export const ADDED_TO_TIMELINE_OR_TEMPLATE_MESSAGE = (fieldOrValue: string, isTimeline: boolean) => i18n.translate('xpack.timelines.hoverActions.addToTimeline.addedFieldMessage', { values: { fieldOrValue, isTimeline }, - defaultMessage: `Added {fieldOrValue} to {isTimeline, select, true {timeline} other {template}}`, + defaultMessage: `Added {fieldOrValue} to {isTimeline, select, true {Timeline} other {template}}`, }); export const COPY_TO_CLIPBOARD = i18n.translate( 'xpack.timelines.dragAndDrop.copyToClipboardTooltip', { - defaultMessage: 'Copy to Clipboard', + defaultMessage: 'Copy to clipboard', } ); diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/add_to_timeline.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/add_to_timeline.test.ts index f17257bb25b3c..44140e84fb9fb 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/add_to_timeline.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/add_to_timeline.test.ts @@ -65,7 +65,7 @@ describe('createAddToTimelineCellAction', () => { }); it('should return display name', () => { - expect(addToTimelineAction.getDisplayName(context)).toEqual('Add to timeline'); + expect(addToTimelineAction.getDisplayName(context)).toEqual('Add to Timeline'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/investigate_in_new_timeline.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/investigate_in_new_timeline.test.ts index 74f0aff7de934..6cb5eba81f03c 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/investigate_in_new_timeline.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/cell_action/investigate_in_new_timeline.test.ts @@ -68,7 +68,7 @@ describe('createAddToNewTimelineCellAction', () => { }); it('should return display name', () => { - expect(addToTimelineAction.getDisplayName(context)).toEqual('Investigate in timeline'); + expect(addToTimelineAction.getDisplayName(context)).toEqual('Investigate in Timeline'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/constants.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/constants.ts index a4b37a6d2fc49..c4c260e31e3d4 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/constants.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/constants.ts @@ -12,13 +12,13 @@ export const ADD_TO_TIMELINE_ICON = 'timeline'; export const ADD_TO_TIMELINE = i18n.translate( 'xpack.securitySolution.actions.cellValue.addToTimeline.displayName', { - defaultMessage: 'Add to timeline', + defaultMessage: 'Add to Timeline', } ); export const INVESTIGATE_IN_TIMELINE = i18n.translate( 'xpack.securitySolution.actions.cellValue.addToNewTimeline.displayName', { - defaultMessage: 'Investigate in timeline', + defaultMessage: 'Investigate in Timeline', } ); @@ -42,15 +42,15 @@ export const ALERTS_COUNT = (entity: string, description: string) => export const ADD_TO_TIMELINE_SUCCESS_TITLE = (value: string) => i18n.translate('xpack.securitySolution.actions.addToTimeline.addedFieldMessage', { values: { fieldOrValue: value }, - defaultMessage: `Added {fieldOrValue} to timeline`, + defaultMessage: `Added {fieldOrValue} to Timeline`, }); export const ADD_TO_TIMELINE_FAILED_TITLE = i18n.translate( 'xpack.securitySolution.actions.cellValue.addToTimeline.warningTitle', - { defaultMessage: 'Unable to add to timeline' } + { defaultMessage: 'Unable to add to Timeline' } ); export const ADD_TO_TIMELINE_FAILED_TEXT = i18n.translate( 'xpack.securitySolution.actions.cellValue.addToTimeline.warningMessage', - { defaultMessage: 'Filter received is empty or cannot be added to timeline' } + { defaultMessage: 'Filter received is empty or cannot be added to Timeline' } ); diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/discover/add_to_timeline.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/discover/add_to_timeline.test.ts index 240ef5a191a2a..70b6651cbf473 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/discover/add_to_timeline.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/discover/add_to_timeline.test.ts @@ -70,7 +70,7 @@ describe('createAddToTimelineDiscoverCellActionFactory', () => { }); it('should return display name', () => { - expect(addToTimelineAction.getDisplayName(context)).toEqual('Add to timeline'); + expect(addToTimelineAction.getDisplayName(context)).toEqual('Add to Timeline'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/lens/add_to_timeline.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/lens/add_to_timeline.test.ts index 65f1938141551..2025249ab02c0 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/lens/add_to_timeline.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/add_to_timeline/lens/add_to_timeline.test.ts @@ -71,7 +71,7 @@ describe('createAddToTimelineLensAction', () => { }); it('should return display name', () => { - expect(addToTimelineAction.getDisplayName(context)).toEqual('Add to timeline'); + expect(addToTimelineAction.getDisplayName(context)).toEqual('Add to Timeline'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/cell_action/copy_to_clipboard.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/cell_action/copy_to_clipboard.test.ts index a7a72fdd967ee..9fa0bfbdf115b 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/cell_action/copy_to_clipboard.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/cell_action/copy_to_clipboard.test.ts @@ -27,7 +27,7 @@ describe('createCopyToClipboardCellActionFactory', () => { }); it('should return display name', () => { - expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to Clipboard'); + expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to clipboard'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/constants.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/constants.ts index 955ff05ddbde8..fd7dd954fd8d7 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/constants.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/constants.ts @@ -11,7 +11,7 @@ export const COPY_TO_CLIPBOARD_ICON = 'copyClipboard'; export const COPY_TO_CLIPBOARD = i18n.translate( 'xpack.securitySolution.actions.cellValue.copyToClipboard.displayName', { - defaultMessage: 'Copy to Clipboard', + defaultMessage: 'Copy to clipboard', } ); diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/discover/copy_to_clipboard.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/discover/copy_to_clipboard.test.ts index 6e939c8fff5f4..ca156fde50c30 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/discover/copy_to_clipboard.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/discover/copy_to_clipboard.test.ts @@ -38,7 +38,7 @@ describe('createCopyToClipboardDiscoverCellActionFactory', () => { }); it('should return display name', () => { - expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to Clipboard'); + expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to clipboard'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/lens/copy_to_clipboard.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/lens/copy_to_clipboard.test.ts index 71f6fa575b7b9..afab1714cca6a 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/lens/copy_to_clipboard.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/lens/copy_to_clipboard.test.ts @@ -63,7 +63,7 @@ describe('createCopyToClipboardLensAction', () => { }); it('should return display name', () => { - expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to Clipboard'); + expect(copyToClipboardAction.getDisplayName(context)).toEqual('Copy to clipboard'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_in.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_in.test.ts index 65894133828fd..72818764f6195 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_in.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_in.test.ts @@ -57,7 +57,7 @@ describe('createFilterInCellActionFactory', () => { } as SecurityCellActionExecutionContext; it('should return display name', () => { - expect(filterInAction.getDisplayName(context)).toEqual('Filter In'); + expect(filterInAction.getDisplayName(context)).toEqual('Filter for'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_out.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_out.test.ts index f4ba4527a2ca1..c562f3ace8d5e 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_out.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/cell_action/filter_out.test.ts @@ -55,7 +55,7 @@ describe('createFilterOutCellActionFactory', () => { } as SecurityCellActionExecutionContext; it('should return display name', () => { - expect(filterOutAction.getDisplayName(context)).toEqual('Filter Out'); + expect(filterOutAction.getDisplayName(context)).toEqual('Filter out'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_in.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_in.test.ts index 08c04bceeda75..da7e47bf258fc 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_in.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_in.test.ts @@ -43,7 +43,7 @@ describe('createFilterInDiscoverCellActionFactory', () => { } as SecurityCellActionExecutionContext; it('should return display name', () => { - expect(filterInAction.getDisplayName(context)).toEqual('Filter In'); + expect(filterInAction.getDisplayName(context)).toEqual('Filter for'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_out.test.ts b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_out.test.ts index 271619f24cf9f..bb77ad30a922d 100644 --- a/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_out.test.ts +++ b/x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/discover/filter_out.test.ts @@ -48,7 +48,7 @@ describe('createFilterOutDiscoverCellActionFactory', () => { } as SecurityCellActionExecutionContext; it('should return display name', () => { - expect(filterOutAction.getDisplayName(context)).toEqual('Filter Out'); + expect(filterOutAction.getDisplayName(context)).toEqual('Filter out'); }); it('should return icon type', () => { diff --git a/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/filter_in.tsx b/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/filter_in.tsx index a1c41463c4579..32d64f87a5c37 100644 --- a/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/filter_in.tsx +++ b/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/filter_in.tsx @@ -16,7 +16,7 @@ import { import { useFilterInOut } from '../hooks/use_filter_in_out'; import { FilterIn } from '../utils/filter'; import { Indicator } from '../../../../common/types/indicator'; -import { FILTER_IN_TITLE } from './translations'; +import { FILTER_FOR_TITLE } from './translations'; const ICON_TYPE = 'plusInCircle'; @@ -60,9 +60,9 @@ export const FilterInButtonIcon: VFC = ({ } return ( - + = ({ } return ( - + - {FILTER_IN_TITLE} + {FILTER_FOR_TITLE} ); @@ -132,7 +132,7 @@ export const FilterInContextMenu: VFC = ({ onClick={filterFn} data-test-subj={dataTestSub} > - {FILTER_IN_TITLE} + {FILTER_FOR_TITLE} ); }; @@ -156,10 +156,10 @@ export const FilterInCellAction: VFC = ({ } return ( - + - - {FILTER_IN_TITLE} + + {FILTER_FOR_TITLE} diff --git a/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/translations.ts b/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/translations.ts index dc46c961794a6..06a5bed526c2b 100644 --- a/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/translations.ts +++ b/x-pack/solutions/security/plugins/threat_intelligence/public/modules/query_bar/components/translations.ts @@ -7,10 +7,10 @@ import { i18n } from '@kbn/i18n'; -export const FILTER_IN_TITLE = i18n.translate('xpack.threatIntelligence.queryBar.filterIn', { - defaultMessage: 'Filter In', +export const FILTER_FOR_TITLE = i18n.translate('xpack.threatIntelligence.queryBar.filterFor', { + defaultMessage: 'Filter for', }); export const FILTER_OUT_TITLE = i18n.translate('xpack.threatIntelligence.queryBar.filterOut', { - defaultMessage: 'Filter Out', + defaultMessage: 'Filter out', }); diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_charts.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_charts.cy.ts index 509ba40e57fc3..ac8ad7ac481a3 100644 --- a/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_charts.cy.ts +++ b/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/alerts_charts.cy.ts @@ -135,7 +135,7 @@ describe('KPI visualizations in Alerts Page', { tags: ['@ess', '@serverless'] }, clickAlertsHistogramLegend(); clickAlertsHistogramLegendAddToTimeline(ruleConfigs.name); - cy.get(TOASTER).should('have.text', `Added ${ruleConfigs.name} to timeline`); + cy.get(TOASTER).should('have.text', `Added ${ruleConfigs.name} to Timeline`); }); }); });