Skip to content

Commit

Permalink
PR comments + test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
joshdover committed Apr 20, 2020
1 parent a7accad commit d9b5162
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 7 deletions.
3 changes: 1 addition & 2 deletions src/plugins/management/public/management_service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ test('Provides default sections', () => {
() => {},
coreMock.createSetup().getStartServices
);
expect(service.getAllSections().length).toEqual(3);
expect(service.getAllSections().length).toEqual(2);
expect(service.getSection('kibana')).not.toBeUndefined();
expect(service.getSection('logstash')).not.toBeUndefined();
expect(service.getSection('elasticsearch')).not.toBeUndefined();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const usePipeline = (
id?: string
) => {
const mounted = usePromise();
const [pipeline, setPipeline] = useState<any | null>(null);
const [pipeline, setPipeline] = useState<any>(null);

useLayoutEffect(() => {
(async () => {
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/logstash/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ import {
import { LicensingPluginSetup } from '../../licensing/public';
import { ManagementSetup } from '../../../../src/plugins/management/public';

// @ts-ignore
import { PLUGIN } from '../common/constants';
// @ts-ignore
import { LogstashLicenseService } from './services';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export default function({ getService }: FtrProviderContext) {
.send({
id: 'fast_generator',
description: 'foobar baz',
username: 'seger',
pipeline: 'input { generator {} }\n\n output { stdout {} }',
})
.expect(204);
Expand Down
1 change: 0 additions & 1 deletion x-pack/test/api_integration/apis/logstash/pipeline/save.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export default function({ getService }: FtrProviderContext) {
.send({
id: 'fast_generator',
description: 'foobar baz',
username: 'seger',
pipeline: 'input { generator {} }\n\n output { stdout {} }',
})
.expect(204);
Expand Down

0 comments on commit d9b5162

Please sign in to comment.