From db54b5e641a72a38d452f6ba523f0111e5bed5fc Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Tue, 6 Jul 2021 08:12:45 -0400
Subject: [PATCH] [ML] Fix embeddable swim lane container to show a scrollbar
 on overflow (#104289) (#104401)

* [ML] fix legend

* [ML] add extra div wrapper for overflow scroll

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
---
 .../explorer/swimlane_container.tsx           | 138 +++++++++---------
 1 file changed, 71 insertions(+), 67 deletions(-)

diff --git a/x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx b/x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx
index d959328218a18..82f8a90fafb7d 100644
--- a/x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx
+++ b/x-pack/plugins/ml/public/application/explorer/swimlane_container.tsx
@@ -40,7 +40,6 @@ import { SWIMLANE_TYPE, SwimlaneType } from './explorer_constants';
 import { mlEscape } from '../util/string_utils';
 import { FormattedTooltip, MlTooltipComponent } from '../components/chart_tooltip/chart_tooltip';
 import { formatHumanReadableDateTime } from '../../../common/util/date_utils';
-import { getFormattedSeverityScore } from '../../../common/util/anomaly_utils';
 
 import './_explorer.scss';
 import { EMPTY_FIELD_VALUE_LABEL } from '../timeseriesexplorer/components/entity_control/entity_control';
@@ -62,6 +61,9 @@ declare global {
   }
 }
 
+function getFormattedSeverityScore(score: number): string {
+  return String(parseInt(String(score), 10));
+}
 /**
  * Ignore insignificant resize, e.g. browser scrollbar appearance.
  */
@@ -122,7 +124,7 @@ const SwimLaneTooltip = (fieldName?: string): FC<{ values: TooltipValue[] }> =>
       label: i18n.translate('xpack.ml.explorer.swimlane.maxAnomalyScoreLabel', {
         defaultMessage: 'Max anomaly score',
       }),
-      value: cell.formattedValue,
+      value: cell.formattedValue === '0' ? ' < 1' : cell.formattedValue,
       color: cell.color,
       // @ts-ignore
       seriesIdentifier: {
@@ -408,73 +410,75 @@ export const SwimlaneContainer: FC<SwimlaneProps> = ({
             grow={false}
           >
             <>
-              <div style={{ height: `${containerHeight}px`, position: 'relative' }}>
-                {showSwimlane && !isLoading && (
-                  <Chart className={'mlSwimLaneContainer'}>
-                    <Settings
-                      onElementClick={onElementClick}
-                      showLegend={showLegend}
-                      legendPosition={Position.Top}
-                      xDomain={xDomain}
-                      tooltip={tooltipOptions}
-                      debugState={window._echDebugStateFlag ?? false}
-                    />
-
-                    <Heatmap
-                      id={id}
-                      colorScale={ScaleType.Threshold}
-                      ranges={[
-                        ANOMALY_THRESHOLD.LOW,
-                        ANOMALY_THRESHOLD.WARNING,
-                        ANOMALY_THRESHOLD.MINOR,
-                        ANOMALY_THRESHOLD.MAJOR,
-                        ANOMALY_THRESHOLD.CRITICAL,
-                      ]}
-                      colors={[
-                        SEVERITY_COLORS.BLANK,
-                        SEVERITY_COLORS.LOW,
-                        SEVERITY_COLORS.WARNING,
-                        SEVERITY_COLORS.MINOR,
-                        SEVERITY_COLORS.MAJOR,
-                        SEVERITY_COLORS.CRITICAL,
-                      ]}
-                      data={swimLanePoints}
-                      xAccessor="time"
-                      yAccessor="laneLabel"
-                      valueAccessor="value"
-                      highlightedData={highlightedData}
-                      valueFormatter={getFormattedSeverityScore}
-                      xScaleType={ScaleType.Time}
-                      ySortPredicate="dataIndex"
-                      config={swimLaneConfig}
-                    />
-                  </Chart>
-                )}
+              <div>
+                <div style={{ height: `${containerHeight}px` }}>
+                  {showSwimlane && !isLoading && (
+                    <Chart className={'mlSwimLaneContainer'}>
+                      <Settings
+                        onElementClick={onElementClick}
+                        showLegend={showLegend}
+                        legendPosition={Position.Top}
+                        xDomain={xDomain}
+                        tooltip={tooltipOptions}
+                        debugState={window._echDebugStateFlag ?? false}
+                      />
 
-                {isLoading && (
-                  <EuiText
-                    textAlign={'center'}
-                    style={{
-                      position: 'absolute',
-                      top: '50%',
-                      left: '50%',
-                      transform: 'translate(-50%,-50%)',
-                    }}
-                  >
-                    <EuiLoadingChart
-                      size="xl"
-                      mono={true}
-                      data-test-subj="mlSwimLaneLoadingIndicator"
+                      <Heatmap
+                        id={id}
+                        colorScale={ScaleType.Threshold}
+                        ranges={[
+                          ANOMALY_THRESHOLD.LOW,
+                          ANOMALY_THRESHOLD.WARNING,
+                          ANOMALY_THRESHOLD.MINOR,
+                          ANOMALY_THRESHOLD.MAJOR,
+                          ANOMALY_THRESHOLD.CRITICAL,
+                        ]}
+                        colors={[
+                          SEVERITY_COLORS.BLANK,
+                          SEVERITY_COLORS.LOW,
+                          SEVERITY_COLORS.WARNING,
+                          SEVERITY_COLORS.MINOR,
+                          SEVERITY_COLORS.MAJOR,
+                          SEVERITY_COLORS.CRITICAL,
+                        ]}
+                        data={swimLanePoints}
+                        xAccessor="time"
+                        yAccessor="laneLabel"
+                        valueAccessor="value"
+                        highlightedData={highlightedData}
+                        valueFormatter={getFormattedSeverityScore}
+                        xScaleType={ScaleType.Time}
+                        ySortPredicate="dataIndex"
+                        config={swimLaneConfig}
+                      />
+                    </Chart>
+                  )}
+
+                  {isLoading && (
+                    <EuiText
+                      textAlign={'center'}
+                      style={{
+                        position: 'absolute',
+                        top: '50%',
+                        left: '50%',
+                        transform: 'translate(-50%,-50%)',
+                      }}
+                    >
+                      <EuiLoadingChart
+                        size="xl"
+                        mono={true}
+                        data-test-subj="mlSwimLaneLoadingIndicator"
+                      />
+                    </EuiText>
+                  )}
+                  {!isLoading && !showSwimlane && (
+                    <EuiEmptyPrompt
+                      titleSize="xxs"
+                      style={{ padding: 0 }}
+                      title={<h2>{noDataWarning}</h2>}
                     />
-                  </EuiText>
-                )}
-                {!isLoading && !showSwimlane && (
-                  <EuiEmptyPrompt
-                    titleSize="xxs"
-                    style={{ padding: 0 }}
-                    title={<h2>{noDataWarning}</h2>}
-                  />
-                )}
+                  )}
+                </div>
               </div>
               {swimlaneType === SWIMLANE_TYPE.OVERALL &&
                 showSwimlane &&