Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Configuration Flyout Issues on Small Viewport Sizes #103778

Closed
MichaelMarcialis opened this issue Jun 29, 2021 · 3 comments · Fixed by #120103
Closed

[Lens] Configuration Flyout Issues on Small Viewport Sizes #103778

MichaelMarcialis opened this issue Jun 29, 2021 · 3 comments · Fixed by #120103
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@MichaelMarcialis
Copy link
Contributor

Kibana version:
8.0.0

Elasticsearch version:
8.0.0-SNAPSHOT

Server OS version:
macOS 10.14.6

Browser version:
Chrome 91.0.4472.114

Browser OS version:
macOS 10.14.6

Original install method (e.g. download page, yum, from source, etc.):
From source

Describe the bug:
At very small viewport sizes, EUI flyouts are intended to cover over the entirety of the page contents (except for the top stacked headers). The Lens configuration flyouts (which use the EUI flyout classes/styles) appear to have two issues occurring at these very small viewport sizes:

  1. The KQL search input z-indexing appears to be placing it above the flyout, when it should be below and overlaid by the flyout.
  2. The right edge of the flyout is not extending to the right edge of the viewport.

Steps to reproduce:

  1. Open a Lens visualization.
  2. Click any chart dimension item to trigger the appearance of a configuration flyout.
  3. Shrink the browser viewport width to trigger the smallest breakpoint layout.

Expected behavior:
When Lens configuration flyouts are opened at small viewport sizes, the KQL search input should appear below and overlaid by the flyout and the right edge of the flyout should extend to the right edge of the viewport.

Screenshots (if relevant):
image

@MichaelMarcialis MichaelMarcialis added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added the good first issue low hanging fruit label Jun 30, 2021
@timductive timductive added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jul 20, 2021
@mbondyra
Copy link
Contributor

mbondyra commented Sep 9, 2021

@MichaelMarcialis this comes from this CSS:
Screenshot 2021-09-09 at 09 40 47

I could overwrite it, but do you know why it is there? 🤔

@MichaelMarcialis
Copy link
Contributor Author

@mbondyra: After looking at this issue again, I believe all EuiFlyout components have this maximum width applied by default. The issue here appears to be threefold:

  1. The EuiFlyout is being positioned to the left edge of the viewport, when it should actually be at the right edge of the viewport. Looks like this is happening because of a left: 0; style being applied to the .lnsDimensionContainer class. At larger viewport sizes this style works, because the flyout is being overriden to have position: absolute;, but at smaller viewport sizes it has the default position: fixed;. This change in positioning styles needs to be accounted for.

  2. As mentioned above,EuiFlyout components do have a default maximum width applied, but in Lens' case I think it makes sense to remove it (as seeing a small sliver of content underneath the flyout doesn't have any usability benefits at small viewport sizes in this app's case). As such, I think we can use a prop of maxWidth={false} on the EuiFlyout component to allow it to fill 100% of the viewport width.

  3. The search bar showing above looks like a simple (hopefully) z-indexing issue. Increasing the z-index of the flyout (or reducing the z-index of the search bar) to accommodate appears to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants