Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add additional restrictions on rollup indices #104003

Closed
wylieconlon opened this issue Jun 30, 2021 · 5 comments
Closed

[Lens] Add additional restrictions on rollup indices #104003

wylieconlon opened this issue Jun 30, 2021 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Jun 30, 2021

The Filters aggregation is not supported on rollups, and the Top values aggregation does not work on meta fields like _index the same way it works regularly. So this causes 4 places that rollups should be restricted more:

  1. No Filters bucket aggregation

Screen Shot 2021-06-30 at 4 48 44 PM

  1. No time shift splitting

Screen Shot 2021-06-30 at 4 50 52 PM

  1. No filtered metrics

Screen Shot 2021-06-30 at 4 51 06 PM

  1. No Top values aggregation on meta fields

Screen Shot 2021-06-30 at 4 49 25 PM

  1. No Cardinality agg on meta fields. (Used in "Unique Count" metric)

Screen Shot 2022-01-11 at 11 38 25 AM

All of the restrictions above should be validated in Formula as well.

@wylieconlon wylieconlon added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@sebelga
Copy link
Contributor

sebelga commented Jan 13, 2022

Probably related this is what I found when testing with a rollup index

  • The _index meta field is empty and thus the Differences does not work

Screenshot 2022-01-12 at 14 42 15

Screenshot 2022-01-12 at 14 42 34

  • I only added average for the rollup and Counter rate does not work in that case

Screenshot 2022-01-12 at 14 40 02

@flash1293
Copy link
Contributor

Another case: No ordering by average elastic/elasticsearch#58967:
Screenshot 2022-03-30 at 12 13 52

@drewdaemon drewdaemon added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Feb 9, 2023
@Heenawter
Copy link
Contributor

Encountered this during 8.7 testing week as well 👍

When trying a count function on a number field:

image

When trying a percentile_rank function on a number field:

image

@timductive
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@timductive timductive closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

8 participants