Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Open modal when user selects "Create default rules" #104051

Open
estermv opened this issue Jul 1, 2021 · 4 comments
Open

[Monitoring] Open modal when user selects "Create default rules" #104051

estermv opened this issue Jul 1, 2021 · 4 comments

Comments

@estermv
Copy link
Contributor

estermv commented Jul 1, 2021

Summary

This issue is a follow up of #101565 to discuss the following feedback point from @katefarrar:

If a user click "Create default rules" from the "Alerts and rules" dropdown they don't receive any type of confirmation until there is a toast notification, which doesn't happen right away. Instead could the default rules modal pop up again and require them to select "Yes" so it's clear they have taken an action?

@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 1, 2021
@estermv estermv added Epic: Stack Monitoring Alerting Alignment Feature:Alerting Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Monitoring Stack Monitoring team and removed needs-team Issues missing a team label labels Jul 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@ravikesarwani
Copy link
Contributor

Do we know how long does it take to create the default rules?
I was thinking if bringing the modal again is really a good option or some kind of "processing" dialog is really a way to go.
In this case user really clicked on the menu to create the default rules and asking them again via a modal "do you really want to create the rules" doesn't seem like the best user experience.

@estermv
Copy link
Contributor Author

estermv commented Jul 7, 2021

I did some testing locally, the endpoint to create the default rules takes around 800ms.

We need to think also about how default rules are going to evolve on stack monitoring? I'm not sure if I remember correctly, but I think we talked or I read about allowing users to create each one of the default rules independently. If we want this, the dropdown will evolve to something more similar to what we have in other pages and the "Create default rules" won't exist.

@smith smith removed the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants