Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Better communicate timeout settings #106400

Closed
Tracked by #166068
Dosant opened this issue Jul 21, 2021 · 3 comments
Closed
Tracked by #166068

[Search] Better communicate timeout settings #106400

Dosant opened this issue Jul 21, 2021 · 3 comments
Labels
docs Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 21, 2021

This came up from a customer who noticed unexpected long-running async searches in their cluster and tried to mitigate the issue by configuring various documented timeout options, but none seem to help.

These are the documented options that historically worked, but with the introduction of async search by default and search session they don't anymore:

kibana.yml:

https://www.elastic.co/guide/en/kibana/current/settings.html

  • elasticsearch.requestTimeout - Time in milliseconds to wait for responses from the back end or Elasticsearch. This value must be a positive integer. Default: 30000. This option doesn't work as expected with async search, as the request run beyond a single request
  • elasticsearch.shardTimeout - Time in milliseconds for Elasticsearch to wait for responses from shards. Set to 0 to disable. Default: 30000. This option isn't used in async search code path.

advanced settings:

  • search:timeout - Change the maximum timeout for a search session or set it to 0 to disable the timeout and allow queries to run to completion. - This seems to be only a client-side option and it would cancel the request only if the user stays on a page` The description also is outdated since we introduced search sessions (7.12). Seems like we also plan to deprecate it: Deprecate search:timeout advanced setting #94912

search sessions settings

Currently in reality what affects the timeout of most of the searches is search session settings:

https://www.elastic.co/guide/en/kibana/7.x/search-session-settings-kb.html

  • xpack.data_enhanced. search.sessions.notTouchedInProgressTimeout - How long a search session can run after a user navigates away without saving a session. The default is 1m.
  • xpack.data_enhanced. search.sessions.defaultExpiration - How long search session results are stored before they are deleted. Extending a search session resets the expiration by the same value. The default is 7d.

I think from Kibana user perspective it could seem that they don't need to look into those settings unless they are using search sessions (saving them), but in reality, it is not currently the case.

I think we need to somehow communicate better what timeout options do. Remove search:timeout to avoid further confusion #94912. And maybe somehow restructure the settings to have central important "async search timeout" on a top-level and not inside search sessions 🤷‍♂️

cc @lukasolson @lizozom @elastic-jb

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana Team:AppServices docs labels Jul 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 22, 2021
@Dosant Dosant changed the title [Search] Better communicate timeout settings [Search] Review timeout settings Nov 30, 2021
@exalate-issue-sync exalate-issue-sync bot changed the title [Search] Review timeout settings [Search] Better communicate timeout settings Nov 30, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 30, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:large Large Level of Effort labels May 23, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 20, 2022
@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 23, 2023
@kertal
Copy link
Member

kertal commented Oct 25, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal added the Icebox label Oct 25, 2023
@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

5 participants