-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC] Index naming: change the way index prefix works #106432
Comments
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
@dhurley14 @jasonrhodes let me know if I misunderstood the requirements for this one |
This is right except we should not use - to separate .alerts with the config value, because we rely on things being in the right order in between the dashes. |
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
This looks good to me (if we leave aside the kibana/packages/kbn-rule-data-utils/src/alerts_as_data_rbac.ts Lines 28 to 35 in 402702d
|
@dhurley14 / @yctercero / @peluja1012 -- what are your thoughts on how this works (doesn't work) alongside RBAC? |
@jasonrhodes this is the issue that was brought up a few weeks ago, but the discussion kind of fizzled out - #104958 Totally agree that hardcoding is not how we want to have it. We were trying to get things in for 7.14 and with I recall there being a few things discussed. We could 1) add state back into the rule registry or 2) find if there's a way to register this with alerting, as RBAC already pulls from it and I think the consensus was that this will eventually end up in there? |
@yctercero thanks! On the one hand, I'm absolutely on board with your option (1), adding some state back into the rule registry. As long as we don't block access to the Alerting Framework's types and APIs, any state that's specific to RAC can be stored in rule registry as far as I'm concerned. That said, for this, I think we just need the RBAC code to be able to read from the config value so that the RBAC can be set up to respect this config value, for now. So we may not need to solve this whole state issue in order to make sure RBAC can work with the "legacy multi-tenancy" situation of letting a user specify a prefix for their indices. |
That sounds plausible. The |
This work is not possible without significant risk, so we have opted for a different solution: #108506 |
Parent ticket: #101016
Summary
Currently, all alerts-as-data indices share a default prefix
.alerts
, so all the indices end up beingKibana admin is able to override this prefix via Kibana config to something like
.kibana_mytenant_alerts
oranyotherprefix
:We were planning to support legacy multi-tenancy via this setting, but after implementing RBAC for alerts, decided to give users less degree of freedom. It would be much easier for RBAC if all alerts-as-data indices started with
.alerts-
no matter what.So, we should change the implementation of index prefix in this way:
If
xpack.ruleRegistry.index
is not specified or blank, we should default to.alerts
:The text was updated successfully, but these errors were encountered: