Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty labels in Timelion are handled incorrectly #10810

Closed
tommikiviniemi-srs opened this issue Mar 20, 2017 · 4 comments
Closed

Empty labels in Timelion are handled incorrectly #10810

tommikiviniemi-srs opened this issue Mar 20, 2017 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@tommikiviniemi-srs
Copy link

tommikiviniemi-srs commented Mar 20, 2017

Kibana version:
5.2.2

Elasticsearch version:
5.2.2

Description of the problem including expected versus actual behavior:
Using the .label() expression in Timelion with an empty string (correctly) prevents the label from being drawn, but all consecutive labels’ values are offset by one.

In the first image there's a line for iOS, and another line just for the .points() part. All queries have labels so this works properly:

Image

Now we hide the .points() line's label:

Image of Yaktocat

Both charts render correctly. First look at the labels in the first image, iOS shows 7 and Android 2, this is correct. However, now look at the labels in the second image, Android's label shows what would have been shown in the HIDDEN label. This is very dangerous as all consecutive labels after the hidden label will show bogus values.

@tommikiviniemi-srs tommikiviniemi-srs changed the title Displaying an empty label in Timelion is handled incorrectly Empty labels in Timelion are handled incorrectly Mar 20, 2017
@tbragin tbragin added Feature:Timelion Timelion app and visualization bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Mar 22, 2017
@gerardliu
Copy link

gerardliu commented Feb 26, 2018

+1 still a bug in Kibana 6.2

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@stefansjs
Copy link

+1 Any chance this will get addressed? Showing incorrect values in the label (but showing the correct name) is really misleading

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 26, 2021
@VladLasitsa
Copy link
Contributor

@stratoula, It was fixed in new implementation of timeline but it still reproducible for old implementation. Can we close it?

@stratoula
Copy link
Contributor

As it has been fixed in the new implementation, yes we can close it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants