Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Bug: Error count threshold alert allows for defining 0 error as threshold, but doesn't show the value #111095

Closed
formgeist opened this issue Sep 3, 2021 · 9 comments
Assignees
Labels
apm:alerting bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

Kibana version

7.15 BC

APM Server version (if applicable)

No response

Elasticsearch version (if applicable)

No response

Steps to Reproduce

CleanShot 2021-09-03 at 10 46 14@2x

CleanShot 2021-09-03 at 10 45 59

  1. Go to create a new rule for an Error count threshold for any service or any environment
  2. Change the error count threshold to 0 which is valid, but the expression doesn't show the value selected

Expected Behavior

I'd expect the value to be shown in the expression 0 errors

Actual Behavior

There's no value shown in the expression which can make it difficult to understand whether the input is valid.

@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.15.0 labels Sep 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv changed the title [APM] Bug: Error cound threshold alert allows for defining 0 error as threshold, but doesn't show the value [APM] Bug: Error count threshold alert allows for defining 0 error as threshold, but doesn't show the value Sep 6, 2021
@sorenlouv
Copy link
Member

Related #108496

@sorenlouv sorenlouv added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Sep 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@sorenlouv
Copy link
Member

@elastic/kibana-alerting-services Does this belong to you, the elastic-charts team or the apm team?

@afgomez
Copy link
Contributor

afgomez commented Sep 8, 2021

@sqren We had a similar error in logs, which was caused by treating the relevant value as falsy when checking for its presence instead of explicitly comparing it with undefined. Maybe something similar happens in APM.

For inspiration, the fix in logs lives in #111150

@sorenlouv
Copy link
Member

@afgomez Thanks! So it sounds like this is a problem in APM and not stack alerting. I'll update the labels then

@sorenlouv sorenlouv removed the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Sep 8, 2021
@botelastic
Copy link

botelastic bot commented Apr 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Apr 13, 2022
@formgeist formgeist removed [zube]: Backlog stale Used to mark issues that were closed for being stale labels Apr 13, 2022
@formgeist
Copy link
Contributor Author

This is still an issue since 8.2.0

CleanShot 2022-04-13 at 12 06 51

@kpatticha
Copy link
Contributor

This should be fixed here: #136919

Please feel free to reopen if you think it hasn't be solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:alerting bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

7 participants