Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Move truncate-by-height into Discover #113414

Closed
timroes opened this issue Sep 29, 2021 · 1 comment · Fixed by #114320
Closed

[Discover] Move truncate-by-height into Discover #113414

timroes opened this issue Sep 29, 2021 · 1 comment · Fixed by #114320
Assignees
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@timroes
Copy link
Contributor

timroes commented Sep 29, 2021

We currently have a truncate-by-height CSS class we're only using in Discover and the source field formatter in kibanaLegacy. We should restructure htis a bit, to help getting rid of the kibanaLegacy plugin (see #76905):

  • Move _source field formatter into Discover and have that code inline, the same as we do for the new data grid implementation.
  • Move the truncate-by-height CSS code into Discover and rewrite it to emotion
  • Move the regristration of the truncate:maxHeight setting from Core into the Discover plugin and also put it into the Discover category there
  • Change documentation and description for the advanced setting to make it more clear it's only affecting Discover

cc @flash1293 @stratoula

@timroes timroes added Feature:Discover Discover Application technical debt Improvement of the software architecture and operational architecture Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 29, 2021
@kertal
Copy link
Member

kertal commented Sep 29, 2021

Here's the PR enabling emotion in Kibana: #98157

And an example how it's used:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants