Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Functional tests in SM React version #114160

Closed
9 tasks done
Tracked by #111309
neptunian opened this issue Oct 6, 2021 · 3 comments
Closed
9 tasks done
Tracked by #111309

[Stack Monitoring] Functional tests in SM React version #114160

neptunian opened this issue Oct 6, 2021 · 3 comments
Labels
Epic: Stack Monitoring de-angularization Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@neptunian
Copy link
Contributor

neptunian commented Oct 6, 2021

Tests are still failing early on due to alerts modal not in yet, but commenting that out I was able to start running individual tests. https://github.com/elastic/kibana/blob/master/x-pack/test/functional/apps/monitoring/index.js. Can skip ones already commented out.

I'm starting on the elasticsearch tests and have found some bugs I'm going to start fixing. I was thinking we can test locally and open PRs for bug fixes. Once it is all passing locally it can be checked off here and then we can open a PR to test they all run.

*Note: Some failing tests are bugs that will be fixed as they are found in other tests and fixed (like a table bug) so make sure there is not already a PR open

@neptunian neptunian added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Epic: Stack Monitoring de-angularization labels Oct 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@klacabane
Copy link
Contributor

Time filter and Setup tests are currently skipped for angular version. For the targeted deadline let's aim for testing parity on the react version and consider enabling them back/improving the testing coverage as a follow-up

@matschaffer
Copy link
Contributor

All checked. Closing down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

5 participants