-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility: Console keyboard focus is trapped #11522
Comments
How about we adjust the UX slightly:
This makes the actions to enter and exit symmetrical and explicit, so users are less likely to unexpectedly end up in a "tabbing cul de sac". I looked for an ARIA role which could communicate this interaction model, but couldn't find anything. The closest thing I could find was the Anyone have any thoughts on how can we communicate to the user that they can interact with this component with enter/esc keypresses? Maybe we can display text instructions once you focus on the element, which we can reference via |
@cjcenizal Assume enter wouldn't be needed for mouse users? They'd just click in correct? |
Right, I think people should still be able to just click on it to enter the editing mode. |
@cjcenizal I find the idea very good! I guess the |
Waiting for reviews on #13339 to reuse it in this issue. |
Problem
The focus state is trapped in any of our code editors.
Proposed solution
The code editors we use should set the "ESC" key to unfocus the cursor on the editor. Futher, we should use an advanced settings accessibility toggle within Kibana to turn off indentation tabbing if set to True.
The text was updated successfully, but these errors were encountered: