Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Info button on Management page #11526

Closed
snide opened this issue Apr 28, 2017 · 4 comments · Fixed by #13341
Closed

Accessibility: Info button on Management page #11526

snide opened this issue Apr 28, 2017 · 4 comments · Fixed by #13341
Assignees
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@snide
Copy link
Contributor

snide commented Apr 28, 2017

Problem

The info button on the management page can't be selected with tab.

Solution

This page has plenty of room. Let's find a place to put the build/commit stuff so it can always be shown.

image

@snide snide added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Apr 28, 2017
@uboness
Copy link

uboness commented Apr 30, 2017

personally I don't think this should be shown at all here. This is a low level info that is not used on a daily basis. We can still expose this info as part of our status page (see our status page as an extended version of the typical about page of a typical app... this is also where the version and potentially build numbers are shown).

@timroes
Copy link
Contributor

timroes commented Jul 4, 2017

I would agree with @uboness. I don't think the build number is something, that would need to be present in the general settings screen (and if I think it should be possibly be shown besides the version (with an info icon as above).

But if it should stay here, this should definitely be focusable (best to make it a real button and not a div button) and have the aria-expanded attribute to show, that it collapses expand an information. Since the information is still "pretty far away" from the button, I think maybe the best solution would be not to make it a button, but using aria-describedby to reference the div with the build number, so a screenreader would read out the label of the icon (which we could set to something like "build information", and after a short pause the actual content of the div).

However, I would still vote for removing it completely :-)

@chrisronline
Copy link
Contributor

chrisronline commented Aug 3, 2017

I'd say let's remove it.

It's not even working properly with the addition of the logstash section. It should show up under the Kibana section.

screen shot 2017-08-03 at 3 43 11 pm

@snide
Copy link
Contributor Author

snide commented Aug 3, 2017

@chrisronline Good by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants