Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic-charts] Amsterdam theme support #117450

Closed
nickofthyme opened this issue Nov 3, 2021 · 3 comments
Closed

[elastic-charts] Amsterdam theme support #117450

nickofthyme opened this issue Nov 3, 2021 · 3 comments
Assignees
Labels
Feature:ElasticCharts Issues related to the elastic-charts library Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@nickofthyme
Copy link
Contributor

Currently, @elastic/charts uses many styles from eui but not yet the Amsterdam theme. This causes issues within the chart legend when :focus states styles are overridden at a root level, such as here....

// We apply brute force focus states to anything not coming from Eui
// which has focus states designed at the component level.
// You can also use "kbn-resetFocusState" to not apply the default focus
// state. This is useful when you've already hand crafted your own
// focus states in Kibana.
:focus {
&:not([class^='eui']):not(.kbn-resetFocusState) {
@include euiFocusRing;
}
}

The fix is for elastic-charts to adopt the Amsterdam theme natively such that the style overrides has no to minimal effect.

@nickofthyme nickofthyme added the Feature:ElasticCharts Issues related to the elastic-charts library label Nov 3, 2021
@nickofthyme nickofthyme self-assigned this Nov 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Feature:ElasticCharts)

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 3, 2021
@nickofthyme nickofthyme added the Team:DataVis Team label for DataVis Team label Nov 3, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 3, 2021
@stratoula
Copy link
Contributor

@nickofthyme can we close this?

@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:DataVis Team label for DataVis Team labels Nov 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ElasticCharts Issues related to the elastic-charts library Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants