Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Offer option to drop 0 values generated by count and sum aggs #119478

Closed
flash1293 opened this issue Nov 23, 2021 · 1 comment · Fixed by #127731
Closed

[Lens] Offer option to drop 0 values generated by count and sum aggs #119478

flash1293 opened this issue Nov 23, 2021 · 1 comment · Fixed by #127731
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Currently some charts behave confusing because the data table passed to the chart does not consistently pass "no data" as a null value in the cell (in case of count or sum, a zero is filled in). To fix this, the agg configs of sum and count have to be extended with an option to turn 0 into null in case there are no documents.

In Lens, a migration has to turn on this flag in the "advanced settings" accordion in the dimension editor, for newly created columns it should be turned off. This will pass the responsibility to handle gaps in the data in a meaningful way to the chart which can handle them in a better way.

For count and sum columns used in formula this switch should be always set to true as it's not possible to use the resulting value in calculations otherwise.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants