Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Usage collector is refreshing the Data Views on every run #123154

Closed
Tracked by #119466
afharo opened this issue Jan 17, 2022 · 2 comments · Fixed by #123155
Closed
Tracked by #119466

[Maps] Usage collector is refreshing the Data Views on every run #123154

afharo opened this issue Jan 17, 2022 · 2 comments · Fixed by #123155
Assignees
@afharo
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Telemetry impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort performance Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Jan 17, 2022 •
edited
Loading

Passing the parameter true in this method causes all the Data Views to be refreshed. Causing an important hit in performance. Especially for large clusters.

kibana/x-pack/plugins/maps/server/maps_telemetry/index_pattern_stats/index_pattern_stats_collector.ts

Line 58 in 586a8fd

const indexPatternIds = await this._indexPatternsService.getIds(true);

APM data that highlighted this issue:
image
@afharo afharo added performance [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Telemetry Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Jan 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

This was referenced Jan 17, 2022
Merged
Closed
Closed
@afharo afharo added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jan 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo self-assigned this Jan 18, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Jan 18, 2022
@afharo afharo mentioned this issue Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Telemetry impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort performance Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maps][Usage collection] Do not refresh Data Views afharo/kibana
2 participants
@afharo @elasticmachine