Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade assistant] Make the reindex server side logic more robust to failures #123816

Open
sebelga opened this issue Jan 26, 2022 · 2 comments
Open
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sebelga
Copy link
Contributor

sebelga commented Jan 26, 2022

While reviewing #123727 I realised that when we shut Kibana in a middle of a re-index operation and then we start Kibana again, the state of the reindex is corrupted.

Once we are back in UA, it first indicate during 30 seconds "Reindexing in progress 10%" until it finally goes to the "Reindex paused" state.

I uploaded here a gif of the issue (the gif is too big for Github). Notice in the Chrome network tab the loop of all the requests made to the server.

I think it would be good that we revisit the server side code of the Upgrade assistant reindexing and make it more robust to different failures.

Note: to be investigated but while working on #123638 we realised with @sabarasaba that the reindex operation saved objects were not cleaned up after a successful reindex. We probably want to delete those SO after reindexing.

@sebelga sebelga added enhancement New value added to drive a business result Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Jan 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@cjcenizal
Copy link
Contributor

cjcenizal commented Jan 26, 2022

I think it would be good that we revisit the server side code of the Upgrade assistant reindexing and make it more robust to different failures.

Just want to note that Upgrade Assistant might look very different after we've redesigned it to support minor upgrades. We could even do something crazy like request specific ES migration APIs so we won't need any reindexing logic at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants