Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Line chart styling controls #124279

Open
Tracked by #175869
ghudgins opened this issue Feb 1, 2022 · 9 comments
Open
Tracked by #175869

[Lens] Line chart styling controls #124279

ghudgins opened this issue Feb 1, 2022 · 9 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ghudgins
Copy link
Contributor

ghudgins commented Feb 1, 2022

Describe the feature:
Control dot size, show/hide dots, line width, line stroke

Describe a specific use case for the feature:
When My data has missing results in time interval buckets
I need to override the default styling with specific dot size, stroke, and line width
So I can achieve the continuous look and feel even when my data is missing buckets

Related discuss post

Would be good for @gvnmagni to remark as to what we should expose from a vis best practices here (at his leisure or when this is planned for a minor release)

@ghudgins ghudgins added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@gvnmagni
Copy link

gvnmagni commented Feb 2, 2022

Premise: What I can say is that typically in data visualization missing data values in time series are treated visually different and since it shouldn't happen frequently the tendency is to make the missing data as prominent as possible. For example, by removing completely the lines that should go among them in order to be extremely clear for the user that we have no values and to avoid implicating increase/decrease in values that are a result of a pure graphical interpolation of points with a line.

But this is just a usual case, which I believe does not apply well to us. Since we could have a lot of time buckets without values, I'm seeing a lot of timeseries that are almost unreadable since we have single dots, far from each other, not connected since we have missing values in between.

What I would suggest is to set by default a visual treatment that would draw the lines (maybe instead of interpolating points that are really far from each other, to make the line go to zero and up again when it reaches the bucket with values) and allow the users to customize it according to their needs. But the starting point would be to draw lines in a way that is clear what's happening without compromising the reading of the chart.

On last thing, for the record, I wouldn't allow full customization for the users, I would let them choose among a series of treatments made by us, as it currently is if I'm correct.

Frame 38

@ghudgins
Copy link
Contributor Author

just an idea (in passing) on how to migrate to new behaviors is to introduce "auto" and turn the existing defaults into a specific configuration.

other problems we are solving if we had better defaults:

  • hard to distinguish between multiple lines even with different color

image

* line does not respond well to changing display size. as the display gets small the line becomes too large.

@flash1293
Copy link
Contributor

@dej611
Copy link
Contributor

dej611 commented Dec 14, 2022

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Jan 16, 2023
@timductive timductive added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jun 14, 2023
@MakoWish
Copy link

No traction on this? I would also like to be able to show dots on the data points of a line chart. We can do it with an aggregation-based line chart, but still not with Lens even on version 8.11.1. I like that you can add layers in Lens, but it still does not quite fully replace the old visualizations.

@stratoula
Copy link
Contributor

@MakoWish thanx for your comment. We are thinking of adding the dots in the data points in Lens but mostly as a switch. This would show/hide the dots and you won't be able to change the radius. Is it something you would be ok with? If not, why would you want to change the sizes? Can you give us examples of some use cases? Thanx!

@MakoWish
Copy link

Hi @stratoula,

It really goes back to the point I have been saying for a long time now. Lens is just not yet a full replacement for the Aggregation Based visualizations. You can adjust the dot size on the Aggregation Based Line graph, so if Lens is supposed to be the new replacement (we are now blocked from using Aggregation Based visualizations with Integrations), the Lens functionalities should at least match what the Aggregation Based visualizations can do. Lens does have a lot of nice things about it (layers for instance), but there are still missing features on it (inability to link to Saved Searches is still my biggest gripe).

The use case would be that my preference on size may not be the same as another customer's preference on the size.


One thing I would like to see is the ability to mix lines, lines with dots, or just dots on the different layers. In certain situations, it helps to visualize differences between the two layers.

In the following example image, the boxes and text above the dots were added graphically, so please ignore those and note only the line for the "average", and the dots for the exact data points.

Chart-50-Shot-load-development-crop

Here is my best attempt with Elastic to do something similar. I have one layer for the individual data points (colored in grayscale), and a second layer for the average. I would like to show just the line for the "average" layer, and just the dots on the specific data points layer; similar to the example above.

elastic_graph_example

@dej611
Copy link
Contributor

dej611 commented Nov 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

10 participants