Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Question: Should Graph bars be tabbable and should they point to a row in the tabular content? #12614

Closed
aphelionz opened this issue Jun 30, 2017 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility

Comments

@aphelionz
Copy link
Contributor

This is very open for discussion. The rows in the table are definitely accessible via sticky mode, and kind of accessible via standard tab navigation. However, the bar charts on the discovery page are not tabbable at all. Should they stay that way?

If not, we can have each bar be accessible via keyboard nav and we could make it point to the appropriate row on the table.

Thoughts from the team?

@tbragin tbragin added the bug Fixes for quality problems that affect the customer experience label Jul 28, 2017
@timroes timroes added the discuss label Aug 3, 2017
@timroes
Copy link
Contributor

timroes commented Aug 3, 2017

I think, we should handle the bar chart as every other bar chart (for which we also don't have a concrete plan yet :D, but at least a discussion in #11842).

I like the idea of being able to jump to a specific place in the table, but currently the bar "clicks" are already used for filtering on that time range (which has a similar effect). I would rather not overwrite the default effects for that specific bar chart, since it is a) complex to implement (and as such lowers the maintainability) and b) I think due to the high amount of different visualization we already have quite some interaction patterns to learn for impaired users, and I would rather not create multiple different interaction patterns per type, depending on where the graph is used.

@timroes
Copy link
Contributor

timroes commented Aug 9, 2017

@cjcenizal @aphelionz any thoughts?

@Bargs
Copy link
Contributor

Bargs commented Aug 16, 2017

I agree the behavior of "clicks" on visualizations should be consistent throughout Kibana.

@timroes
Copy link
Contributor

timroes commented Aug 22, 2017

Closing this for now, with the first decision of being consistent throughout Kibana. If we are able to do some real user testing and see that such a feature would be a good idea, we can reopen this ticket and revisit the topic.

The actual barchart itself is made compliant by showing a warning in the short term (#13572) and in the long term by (#11842).

@timroes timroes closed this as completed Aug 22, 2017
@timroes timroes removed the discuss label Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility
Projects
None yet
Development

No branches or pull requests

5 participants