Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] replace hardcoded english strings with i18n #127705

Closed
5 of 10 tasks
Bamieh opened this issue Mar 15, 2022 · 6 comments
Closed
5 of 10 tasks

[i18n] replace hardcoded english strings with i18n #127705

Bamieh opened this issue Mar 15, 2022 · 6 comments
Assignees
Labels
impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Mar 15, 2022

There are a few obvious places we have in Kibana that are missing i18n. This issue does not include everything missing; The goal of this issue is to make sure we have decent coverage in each main user flow, landing page, welcome screen, date pickers, sidenave, topnav, etc.

Preparations:

  • Spin a 8.2 test cluster to identify missing i18n (French and pseudo english)
  • Receive the latest translation files for testing
  • Define some of the main user flows to test coverage against
  • Manually go over the main screens of every domain and make sure we are not missing any translations

Missing i18n

Notes

Why are we manually testing coverage?

Unfortunately, we don't have any tooling around testing i18n coverage at the moment. I've opened an issue to discuss supporting frontend coverage to at least have some guarantees on the frontend #127708

Why not aim to have full i18n coverage?

We have 120k+ words in kibana and checking for coverage manually as a diminishing return on time invested. Since we do not have an automated tool to ensure a minimum level of coverage, the level of coverage will keep fluctuating between releases so it is impossible.

Some labels are internationalized but still in English?

  1. The French extraction was 6 months ago so there is a big gap in coverage that will automatically be addressed upon the 8.2 extraction.
  2. Services and brand names like Canvas, Kibana, Elasticsearch, etc are intentionally left in English by translators. We do not have a list of keywords that we keep in English but I refer to the elastic.co website to see which keywords are not translated when I get asked.
  3. It could be a possible bug. Our i18n package is using the old react context which sometimes bugs out. Please surface those bugs so we can fix them since detecting those is tricky and purely manual until we upgrade the intl package ([i18n] React-Intl v3 soon out of beta #38642)
@Bamieh Bamieh added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n loe:small Small Level of Effort labels Mar 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 15, 2022
@Bamieh Bamieh self-assigned this Mar 17, 2022
@alexfrancoeur
Copy link

An early snapshot was spun up with French enabled and it looks like the Enterprise Search description on the home page is not translated. Adding here to track as we work through the 8.2 translation.

image (95)

@Bamieh Bamieh reopened this Apr 5, 2022
@Bamieh
Copy link
Member Author

Bamieh commented Apr 5, 2022

I will keep this issue open until 8.2 GA to allow more feedback until the next extraction in May. After this issue is closed I will create another issue for 8.x to have a place for people to submit hardcoded strings for the teams to update.

I'm fighting with the exalate-issue-sync to keep this open since I linked it to a resolved task 🙃

@Bamieh Bamieh reopened this Apr 6, 2022
@rseldner
Copy link

rseldner commented Apr 7, 2022

A user has graciously provided a list of Japanese translations. Based on Kibana 8.1.0.

    default i18n.locale: "ja-JP"    
No. location string current string desired string note
1 home title Welcome home ようこそホーム ようこそ "ようこそホーム" is strange as Japanse
2 home menu Home Home ホーム  
3 home menu Analytics Analytics 分析  
4 home menu Discover Discover 探索  
5 home menu Dashboard Dashboard ダッシュボード  
6 home menu Canvas Canvas キャンバス  
7 home menu Graph Graph グラフ  
8 home menu Visualize Library Visualize Library ビジュアライゼーションライブラリ  
9 Visualize Library title Visualize Library Visualizeライブラリ ビジュアライゼーションライブラリ  
10 Visualize Library create button Create visualization Createビジュアライゼーション ビジュアライゼーションを作成  
11 New visuazlization aggregation アグリゲーション 集約 "aggragation" is translated  as "集約" in another place
12 time filter last last 過去  
13 time filter next next 今後  
14 time filter seconds seconds 秒間  
15 time filter minutes minutes 分間  
16 time filter hours hours 時間  
17 time filter days days 日間  
18 time filter weeks weeks 週間  
19 time filter months months か月間  
20 time filter years years 年間  
21 time filter Refresh every 以下の感覚ごとに更新 以下の間隔ごとに更新  
22 visualization Inspect 検査 詳細を見る Japanese '検査' is similar to 'test'.
23 filter operator is is 等しい  
24 filter operator is not is not 等しくない  
25 filter operator is one of is one of いずれか  
26 filter operator is not one of is not one of いずれでもない  
27 filter operator is between is between 範囲内  
28 filter operator is not between is not between 範囲外  
29 dashboard Create dashboard Createダッシュボード ダッシュボードを作成  
30 home -> spaces spaces spaces スペース  
31 dashboard list Search... Search... 検索...  
32 dashboard list Rows per page Rows per page ページごとの行数  
33 Visualize Library list Search... Search... 検索...  
34 Canvas Canvas Canvas キャンバス  
35 Canvas Add your first workpad 初の’ワークパッドを追加しましょう 初のワークパッドを追加しましょう Unnecessary "’"
36 Canvas template Search... Search... 検索...  
37 Canvas template Rows per page Rows per page ページごとの行数  
38 Canvas list Rows per page Rows per page ページごとの行数  
39 Discover -> Inspect Inspector インスペクター 詳細  
40 Discover -> Inspect Request Request リクエスト  

@Bamieh
Copy link
Member Author

Bamieh commented Apr 7, 2022

Thank you @rseldner

@Bamieh
Copy link
Member Author

Bamieh commented Jul 23, 2024

Closing this as resolved. If we need another run of testing we'd open a new issue

@Bamieh Bamieh closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

4 participants