Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] remove geojson implementation for displaying individual elasticsearch documents #133396

Closed
Tracked by #154870
nreese opened this issue Jun 2, 2022 · 3 comments
Closed
Tracked by #154870
Labels
enhancement New value added to drive a business result Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Jun 2, 2022

There are 2 implementation paths for displaying individual elasticsearch documents in maps

  1. geojson: documents fetched from _search API. ASCII hits results are transformed into geojson feature collection and added to map as 'geojson' maplibre source.
  2. vector tiles: documents fetched from _mvt API. Binary vector tiles results added to map as 'vector' maplibre source.

There are 3 benefits to removing geojson implementation

  1. Simplify user interface: Current system leaks implementation details to the user. In the screen shot below, users are asked to pick between geojson and vector tiles.
    Screen Shot 2022-06-02 at 7 01 03 AM
  2. performance: geojson is significantly slower than vector tiles. Large shapes with numerous vertices have huge ASCII response payloads.
  3. maintenance: Less code paths are easier to maintain

Geojson implementation can not be removed until the following feature gaps are closed:

  • Formatted labels
  • Multiple term joins
  • Data driven styling from term join metrics with 'Label', 'Label size', icon 'Symbol size', and 'Symbol orientation' style properties
  • Data driven styling from scripted fields
@nreese nreese added Meta [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result labels Jun 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@jb1b84 jb1b84 added Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jb1b84 jb1b84 removed the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Nov 3, 2022
@nreese nreese added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 26, 2023
@nreese
Copy link
Contributor Author

nreese commented Apr 12, 2023

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Maps ice box #154870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Meta Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants