Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics] Fix functional tests for tooltip #137903

Closed
neptunian opened this issue Aug 2, 2022 · 3 comments
Closed

[Metrics] Fix functional tests for tooltip #137903

neptunian opened this issue Aug 2, 2022 · 3 comments
Labels
Feature:Metrics UI Metrics UI feature info-needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@neptunian
Copy link
Contributor

neptunian commented Aug 2, 2022

Tooltip functional test is commented out in this PR because it's failing after commenting back in Metrics UI Home Page test suite it belongs to which was commented out here #106650 due to flakey Saved Views tests.

  • After [Unified Observability] update network fields #134471 was merged the field we used for getting network in/out has changed. Tests for the tooltip metric values are broken due to the fact that host.network.ingress.bytes and host.network.egress.bytes doesn't exist in the es archive data so the data needs to be updated. Note the ECS fields were introduced in 7.14 and may not make sense in this archive data as we agreed in [Unified Observability] Metrics overview table is not showing RX or TX metrics although they're available #131152 (comment) that users before this version would not get the data, so we could simply update the values to '-' which is correct for <7.14 and test for older versions that there is a value. I also think we can simplify this test and don't need to test for exact values as its covered elsewhere, perhaps just checking values exist and the tooltip is showing for the first node in the waffle map
  • The other thing breaking which only happens consistently in CI and not locally is the tooptip is not showing at all
@neptunian neptunian added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Aug 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@smith smith added the Feature:Metrics UI Metrics UI feature label Aug 3, 2022
@roshan-elastic
Copy link

Hey @neptunian - checking if this is still needed?

It looks like this impacts Inventory but checking if it impacts anything else?

Trying to understand the value of performing this work over other work (so I can prioritise).

@neptunian
Copy link
Contributor Author

I believe I resolved this so I will close it. However ALL of our tests for the Home Page (inventory) are currently being skipped since last month. We should try to fix these before the release. #157713. CC @smith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature info-needed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants