Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Saved object management] Add ability to search content containing pipe character #172693

Open
drewdaemon opened this issue Dec 6, 2023 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc usability

Comments

@drewdaemon
Copy link
Contributor

Describe the feature:
Right now we don't allow the pipe character when searching for content in the table list view or the saved objects management page.

Screenshot 2023-12-06 at 7 59 42 AM

Describe a specific use case for the feature:
We received internal feedback that this could be a useful thing to search for (for example, ES|QL could be in the title of a dashboard).

@drewdaemon drewdaemon added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Dec 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@drewdaemon
Copy link
Contributor Author

Not sure who should actually own this. Feel free to reassign.

@drewdaemon
Copy link
Contributor Author

Now I see #151120 so I will change this issue to just cover saved object management.

@drewdaemon drewdaemon changed the title Add ability to search content containing pipe character [Saved object management] Add ability to search content containing pipe character Dec 6, 2023
@pgayvallet
Copy link
Contributor

The SO management search bar is using EUI's Query syntax language under the hood (like the navigational search, and many other search fields in Kibana do for example). Therefore, special characters (as | is) must be escaped using double quotes around the terms.

Screenshot 2023-12-08 at 09 07 14

Functionally, this is working as expected.

Now, we may want to more explicitly inform somewhere on the page that the search bar is using EUI's Query syntax and may want to link to its documentation.

@petrklapka petrklapka removed the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc usability
Projects
None yet
Development

No branches or pull requests

4 participants