Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [PRC Milestone 3] Update KQL filters and convertRulesFilterToKQL method to rely on new Prebuilt schema #175708

Closed
jpdjere opened this issue Jan 26, 2024 · 4 comments
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@jpdjere
Copy link
Contributor

jpdjere commented Jan 26, 2024

Prebuilt Rule Customization Epic - Milestone 3: #174168
Main Epic: https://github.com/elastic/security-team/issues/1974 (internal)

Additional Material:
- Milestone 3 - Software Design RFC
- Prebuilt Rules Customization Technical Design


Description:

Across our application, both in the frontend and serverside, we use KQL filters to retrieve rules based on whether they are prebuilt rules or not - this means that the current behaviour of these values relies on the immutable field being set to either true or false.

With the introduction of the new prebuilt field, we will want to rely on this new field to determine if a rule is prebuilt during retrieval of rules.

At the same time, we need to maintain backwards compatibility: in order to determine if a rule is prebuilt, preferentially search for the existence of the prebuilt field; if that doesn't exist, fallback to the legacy logic of checking a rule's immutable value.

This means that we will need to update the constants and KQL filters that we have hardcoded in our application, as well as the convertRulesFilterToKQL method, to reflect the new schema.

The updates needed are described in the KQL filters and the convertRulesFilterToKQL method section of the RFC.

@jpdjere jpdjere added release_note:skip Skip the PR/issue when compiling release notes Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Jan 26, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 26, 2024
@jpdjere jpdjere added the Team:Detection Rule Management Security Detection Rule Management Team label Jan 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 26, 2024
@jpdjere jpdjere added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. needs-team Issues missing a team label labels Jan 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere
Copy link
Contributor Author

jpdjere commented Apr 9, 2024

Closing in favour of new tickets planned: #174168 (comment)

@jpdjere jpdjere closed this as completed Apr 9, 2024
@banderror banderror closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

3 participants