Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Vertex Content Render should not use custom icons where possible #18111

Closed
elasticmachine opened this issue Jan 10, 2018 · 4 comments
Assignees
Labels

Comments

@elasticmachine
Copy link
Contributor

Original comment by @pickypg:

While trying to remove the custom alert icons from Monitoring, I ran into an issue where alert-blue (aka the blue i within a circle) was referenced by the Vertex Content Render.

LINK REDACTED

This code is all directly creating the HTML that it uses with d3, but ideally we can swap over to the EUI version of the icon(s).

It is also using some other custom SVG icons, but those do not have an alternative in the EUI. (<EuiIcon type="iInCircle" /> if you can use React)

@elasticmachine
Copy link
Contributor Author

Original comment by @ycombinator:

The "blue i within the circle" icon is actually LINK REDACTED from the Pipeline Viewer, likely as early as 6.2, as part of LINK REDACTED So that one can be deleted once LINK REDACTED is merged.

Unfortunately the other icons are all very specific to the Pipeline Viewer. @snide Should versions of these exist in EUI? The icons are:

  • Input plugin: LINK REDACTED
  • Filter plugin: LINK REDACTED
  • Output plugin: LINK REDACTED
  • Queue: LINK REDACTED
  • If condition: LINK REDACTED

@elasticmachine
Copy link
Contributor Author

Original comment by @snide:

Yes. Can you add the requests to elastic/eui#219

We'll give you icons in EUI.

@ycombinator
Copy link
Contributor

The Vertex Content Renderer was removed by @justinkambic in #20122. So this issue is now moot. Closing.

@ycombinator
Copy link
Contributor

Related: #46415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants