Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] [Controls] Fix control creation #187504

Closed
Heenawter opened this issue Jul 3, 2024 · 1 comment · Fixed by #187606
Closed

[Embeddable Rebuild] [Controls] Fix control creation #187504

Heenawter opened this issue Jul 3, 2024 · 1 comment · Fixed by #187606
Assignees
@Heenawter
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Jul 3, 2024 •
edited
Loading

Describe the feature:
Currently, the custom control options component expects a state manager to be passed to it in order to "tell" the editor that changes were made - this works great for editing, but not so great for creation since we still don't have inline editing. We need to update the CustomOptionsComponent so that it works for both creation and editing.

As part of this, I will create a mocked "add control" button in the React controls example. I will also be adding tests for the DataControlEditor component, hence the "medium" size
@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. project:embeddableRebuild labels Jul 3, 2024
@Heenawter Heenawter self-assigned this Jul 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter mentioned this issue Jul 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embeddable Rebuild] [Controls] Refactor control editing + creation Heenawter/kibana
2 participants
@Heenawter @elasticmachine