Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Relabel documents to results #197779

Closed
kertal opened this issue Oct 25, 2024 · 6 comments · Fixed by #197833
Closed

[Discover] Relabel documents to results #197779

kertal opened this issue Oct 25, 2024 · 6 comments · Fixed by #197833
Assignees
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Oct 25, 2024

📓 Summary

Currently in Discover we describe our results in the Data table as "Documents". This is inaccurate since we now have ES|QL providing results based on aggregations. Therefore the "Documents" labeling in Discover should be changed to "Results".

Image

✔️ Acceptance criteria

  • Discover's data table shall display "Results" instead of "Documents"
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Oct 25, 2024
@kertal kertal added the loe:small Small Level of Effort label Oct 25, 2024
@jughosta
Copy link
Contributor

Plus for "X documents" on for a saved search panel on Dashboard.

@jughosta
Copy link
Contributor

Closed via #197833

@florent-leborgne
Copy link
Contributor

@jughosta @kertal Quick question as I'm editing the release notes for 8.16... Is this renaming for the ES|QL mode only?

@jughosta
Copy link
Contributor

Hi @florent-leborgne,

Yes, only for ES|QL as Documents does not always fit.

@florent-leborgne
Copy link
Contributor

Ok gotcha, I thought this was initially meant for the classic mode as well to keep the wording aligned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants