Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization created from ES|QL saved search not showing Inspect option #202301

Closed
laraMorenoIgle opened this issue Nov 29, 2024 · 6 comments · Fixed by #202947
Closed

Visualization created from ES|QL saved search not showing Inspect option #202301

laraMorenoIgle opened this issue Nov 29, 2024 · 6 comments · Fixed by #202947
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@laraMorenoIgle
Copy link
Contributor

Kibana version: 8.16.1

Elasticsearch version: 8.16.1

Describe the bug:
When saving an ES|QL search and adding it to a dashboard using the add from library option, we don't have the inspect button.

Note: If you click on add panel option and then you choose ES|QL, the Inspect option is displayed. So in this case it works fine.

Steps to reproduce:

  1. In Discover create a ES|QL search and save it.
    Image

  2. Create a Dashboard and click on add from library and select your ES|QL saved search.

  3. Now, if you click on the three dots menu for such visualization you will see that the Inspect option is not displayed

Image
Image

Expected behavior:
Being able to "inspect" the ES|QL query.

@laraMorenoIgle laraMorenoIgle added bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Nov 29, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 29, 2024
@jsanz jsanz added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 29, 2024
@jsanz
Copy link
Member

jsanz commented Nov 29, 2024

Not totally sure this falls in the Presentation team realm since this is from Dashboards, but let's start from here.

@Heenawter
Copy link
Contributor

Looks like the saved search embeddable isn't implementing the HasInspectorAdapters interface. Reassigning to the @elastic/kibana-data-discovery team to see how they want to handle this :)

@Heenawter Heenawter added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 29, 2024
@davismcphee
Copy link
Contributor

Reassigning to the @elastic/kibana-data-discovery team to see how they want to handle this :)

@Heenawter Ideally the right way 😁 Any chance you have a link to a good implementation for this that we could use as a reference for the saved search embeddable?

@Heenawter
Copy link
Contributor

Heenawter commented Nov 29, 2024

@davismcphee Lens, visualization, and maps all implement this interface - Lens is definitely the most complicated, so I would suggest looking at visualize or maps:

getInspectorAdapters: () => inspectorAdapters$.getValue(),

getInspectorAdapters: () => {
return getInspectorAdapters(store.getState());
},

@kertal kertal added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Nov 29, 2024
@davismcphee
Copy link
Contributor

@Heenawter Excellent, thank you! We will get this fixed ASAP.

@jughosta jughosta self-assigned this Dec 4, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 5, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 3f0008a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 5, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 3f0008a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 5, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 3f0008a)
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this issue Dec 9, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this issue Dec 10, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this issue Dec 11, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
)

- Closes elastic#202301

## Summary

This PR enables "Inspect" option for saved search Dashboard panels.

<img width="1619" alt="Screenshot 2024-12-04 at 16 02 33"
src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578">
<img width="1620" alt="Screenshot 2024-12-04 at 16 02 43"
src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924">
<img width="1618" alt="Screenshot 2024-12-04 at 16 03 03"
src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana Feature:Visualizations Generic visualization features (in case no more specific feature label is available) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants