-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization created from ES|QL saved search not showing Inspect option #202301
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
Not totally sure this falls in the Presentation team realm since this is from Dashboards, but let's start from here. |
Looks like the saved search embeddable isn't implementing the |
@Heenawter Ideally the right way 😁 Any chance you have a link to a good implementation for this that we could use as a reference for the saved search embeddable? |
@davismcphee Lens, visualization, and maps all implement this interface - Lens is definitely the most complicated, so I would suggest looking at visualize or maps:
kibana/x-pack/plugins/maps/public/react_embeddable/initialize_redux_sync.ts Lines 175 to 177 in 8d2e28a
|
@Heenawter Excellent, thank you! We will get this fixed ASAP. |
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 3f0008a)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 3f0008a)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 3f0008a)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
) - Closes elastic#202301 ## Summary This PR enables "Inspect" option for saved search Dashboard panels. <img width="1619" alt="Screenshot 2024-12-04 at 16 02 33" src="https://github.com/user-attachments/assets/a1eab597-4683-4069-b48f-b33b977db578"> <img width="1620" alt="Screenshot 2024-12-04 at 16 02 43" src="https://github.com/user-attachments/assets/0dc734c3-f930-4397-9b68-69d959400924"> <img width="1618" alt="Screenshot 2024-12-04 at 16 03 03" src="https://github.com/user-attachments/assets/460d8432-dc14-480e-b49d-81ab743815d2"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Kibana version: 8.16.1
Elasticsearch version: 8.16.1
Describe the bug:
When saving an ES|QL search and adding it to a dashboard using the
add from library
option, we don't have the inspect button.Note: If you click on
add panel
option and then you chooseES|QL
, theInspect
option is displayed. So in this case it works fine.Steps to reproduce:
In Discover create a ES|QL search and save it.
Create a Dashboard and click on
add from library
and select yourES|QL
saved search.Now, if you click on the three dots menu for such visualization you will see that the
Inspect option
is not displayedExpected behavior:
Being able to "inspect" the ES|QL query.
The text was updated successfully, but these errors were encountered: