Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] React@18 legacy mode upgrade QA #203114

Open
6 tasks done
Dosant opened this issue Dec 5, 2024 · 1 comment
Open
6 tasks done

[Meta] React@18 legacy mode upgrade QA #203114

Dosant opened this issue Dec 5, 2024 · 1 comment
Assignees
Labels
Meta React@18 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 5, 2024

Shared UX team is working on React@18 upgrade.

We plan to upgrade in 2 phases:

  1. Phase 1: Upgrade React packages to version 18 and keep running in Legacy mode, which should behave mostly similarly to React@17.
  2. Phase 2: Gradually migrate to Concurrent mode.

We’re almost ready to complete phase 1:

  • All types breaking changes have been addressed and Kibana is already using @types/react@18 in main
  • We’re finishing fixing unit tests and breaking changes. Kibana is already using the latest @testing-library/react in main and we’re finalizing the breaking changes that are backward compatible and can be merged separately.
  • We’ve addressed all runtime issues found by functional tests and CI functional tests are now green when running with React@18.

Kibana’s UI functional tests coverage and a very small number of discovered runtime issues give us a lot of confidence, but we would like to ask teams to help with manually testing their UIs to try to discover any UI issues that could have been missed by functional testing.

The purpose of this meta issue is to track any runtime issues caused by an upgrade to React@18 in Legacy Mode.

Runtime issues discovered by functional tests

Issues discovered outside of functional tests

... Please add any issues that are found outside of functional tests ...

@Dosant Dosant added Meta React@18 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Dec 5, 2024
@Dosant Dosant self-assigned this Dec 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta React@18 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

2 participants