Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactify route-based errors #20543

Closed
cjcenizal opened this issue Jul 8, 2018 · 1 comment
Closed

Reactify route-based errors #20543

cjcenizal opened this issue Jul 8, 2018 · 1 comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@cjcenizal
Copy link
Contributor

We currently have three errors which are surfaced via individual Angular routes:

We'll need to convert this code to React. As part of this process, we should consider removing the need for specialized routes altogether since the UX of allowing a user to navigate to an error page when there's no error doesn't make sense. It also seems unhelpful to navigate out of the context which caused the error. As an alternative we could display a large modal. We should also ask our copywriting team to take a look over the copy while we're at it.

@cjcenizal cjcenizal added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Jul 8, 2018
@pgayvallet
Copy link
Contributor

Closing. Url overflow error page has been migrated to KP, the two others are no longer a thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants