Discover histogram legend is missing

[LeeDr]

Kibana version: 6.4.0

Elasticsearch version: 6.4.0

Server OS version: 6.4.0 on Windows 2012 Server, 6.3.0 on Cloud

Browser version: Chrome

Browser OS version: Ubuntu

Original install method (e.g. download page, yum, from source, etc.): zip files for Windows

Describe the bug: I can see in 5.6 you could click an arrow to show the Discover histogram legend. Of course it always only shows "Count" in Discover. But it also let you pick the color for your bars.

5.6 on Cloud:

In 6.3 or 6.4 I can't find the little arrow to open that legend:

Steps to reproduce:

1. Go to Discover
2. look for button to expand the legend
3. it's not there

Expected behavior: Showing that the bars are "Count" is pretty trivial, but it appears to be a regression from 5.6 to 6.3 (or earlier) that users can't set the color of the histogram any longer.

Screenshots (if relevant): See above

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

[lukasolson]

Not sure this is really a bug. If all users can do here is modify the color of the bars, what value does this provide? The resulting saved search that is embedded on a dashboard will not show a histogram anyway.

[LeeDr]

@lukasolson Are you saying it was removed on purpose? It maybe be a minor feature (maybe almost useless), but we don't know if some users were using it. I wouldn't call it a blocker, but unless we made a decision that it should be removed, then I would still call it a regression bug. If it was removed on purpose for some reason, there should be a PR we can reference.

[lukasolson]

@elastic/kibana-visualizations Any idea why this might have happened?

[timroes]

Looking at the code, this legend should have been disabled since basically forever (4.0.0). The appropriate flag has been set in this commit: 03950cf#diff-7aac05df5046a0b2667ffd3a4e9d0b95R603

It was rather an issue, that this actually didn't have any effect. This was apparently changed in 6.0, and since 6.0 the legend is hidden as it was supposed to be. So this should not be a bug, but rather an enhancement request, if we want to show the legend in the chart again.

My personal opinion on that: The only reason I see the legend makes sense there is to change colors. I think that should rather be solved in the long run, by having proper color palette solution for charts in Kibana (see #17764).

I removed the bug label. @elastic/kibana-discovery if we don't plan to show the legend again (e.g. for above reasons), I think we can close this issue.

[lukasolson]

Playing around with this, I have to agree with @timroes, the behavior here is that the legend should not be shown. Even if you did change the color, it's not saved as part of the saved search, which means if you re-load the same exact saved search, the color changes back to the default.

I personally haven't seen any issue prior to this raised, and haven't heard any complaints from users needing to change colors in the histogram here in discover. I think we're good to close this. @LeeDr feel free to remove this from the list of things we need to test for.