Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Splash screen] Show per user, not per user per space #24030

Closed
alexfrancoeur opened this issue Oct 15, 2018 · 2 comments
Closed

[Splash screen] Show per user, not per user per space #24030

alexfrancoeur opened this issue Oct 15, 2018 · 2 comments
Labels
Feature:Add Data Add Data and sample data feature on Home Feature:Home Kibana home application Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@alexfrancoeur
Copy link

The splash screen looks fantastic! I know we had an async conversation in the last PR and I thought we had concluded to go with per user vs. per user, per space (#21353 (comment)). Though reading through the comments, I'm not really sure if we did.

Today, we are showing the splash screen per user per space. This can be a bit frustrating as both a new and power user. Would it be possible to only show the splash screen per user if there is no data instead of per user, per space?

cc: @chrisdavies @stacey-gammon @timroes @legrego @kobelb

@alexfrancoeur alexfrancoeur added Feature:Add Data Add Data and sample data feature on Home Feature:Home Kibana home application Feature:Security/Spaces Platform Security - Spaces feature labels Oct 15, 2018
@alexfrancoeur
Copy link
Author

alexfrancoeur commented Oct 15, 2018

Ideally, we fix this before 6.5

@legrego
Copy link
Member

legrego commented Oct 15, 2018

@alexfrancoeur just to confirm, are you seeing the screen appear in other spaces after clicking "Explore on my own"? In my earlier testing, dismissing the screen in one space would be respected in all spaces.

If you choose to add data in one space, then I think the dialog continues to appear in subsequent spaces. Is this the scenario you'd like changed? If so, it might have to be something simple, like always hiding the welcome screen after pressing either button, even if they choose not to add sample data after saying they want to.

Would it be possible to only show the splash screen per user if there is no data instead of per user, per space?

The welcome screen will check to see if any index patterns exist before displaying. This check uses the Saved Objects Client, which is transparently space-aware, and will only return results for the current space. In other words, we don't have a way to search across all spaces here.

@tylersmalley tylersmalley added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Add Data Add Data and sample data feature on Home Feature:Home Kibana home application Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

3 participants