Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate canvas plugin system to New Platform #24513

Closed
stacey-gammon opened this issue Oct 24, 2018 · 4 comments
Closed

Migrate canvas plugin system to New Platform #24513

stacey-gammon opened this issue Oct 24, 2018 · 4 comments
Labels
Feature:Canvas Feature:New Platform Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stacey-gammon
Copy link
Contributor

Canvas introduced a new mechanism for users to write plugins (something like dropping function definitions in a folder, I think). This is different than the current way we expect users to write plugins.

We should:

  • Figure out if Canvas can use the current system rather than introduce a new one
  • If there is a legitimate reason for Canvas to use a new system, can it be integrated into the current system, possibly only in New Platform, so it's an officially supported plugin mechanism in core?

We should do this before we GA. Once users start writing plugins using this new method, it will be harder to consolidate the approaches, if we want to continue supporting the plugins that were written in the interim.

cc @epixa @elastic/kibana-canvas

@stacey-gammon stacey-gammon added blocker v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 24, 2018
@stacey-gammon stacey-gammon changed the title Replace, or merge, Canvas plugin system with core Migrate canvas plugin system to New Platform Jan 25, 2019
@stacey-gammon
Copy link
Contributor Author

We decided to move forward with a new platform migration, however, it looks like there are some dependencies blocking this effort, and it will likely be a lot of work, so removing the 7.0 and blocker labels, though this will be a blocker for Canvas GA.

@stacey-gammon
Copy link
Contributor Author

stacey-gammon commented Jan 25, 2019

related:

@stacey-gammon stacey-gammon added :AppArch Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2019
@cqliu1
Copy link
Contributor

cqliu1 commented Apr 30, 2019

Closing this issue since Canvas doesn't use a separate plugin system anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas Feature:New Platform Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants