Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Combo boxes labels not read in Selected Layer Display tab #25510

Closed
aphelionz opened this issue Nov 10, 2018 · 3 comments · Fixed by #54661
Closed

[Accessibility] Combo boxes labels not read in Selected Layer Display tab #25510

aphelionz opened this issue Nov 10, 2018 · 3 comments · Fixed by #54661
Assignees
Labels
enhancement New value added to drive a business result impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A

Comments

@aphelionz
Copy link
Contributor

aphelionz commented Nov 10, 2018

Steps to reproduce (assumes ChromeVox or similar)

  1. Open Kibana in a new tab
  2. Tab to Canvas
  3. Select an existing or create a new canvas
  4. Select a layer or create a new eleemnt
  5. Tab through the fields on the "Select Layer" panel on the right

screenshot_20181110_212231

Actual Result
6. The announcements of many elements are simply "drop down" or "button"

Expected Result
6. Labeling should be consistent and informative. In the above image, the announcements should be "Select a Shape", "Fill", "Border", etc.

#24159 Kibana 6.5 Meta Issues
#23534 Canvas Accessibility

Relevant WCAG Criteria: 3.3.2 Labels or Instructions

@aphelionz aphelionz added Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 11, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@aphelionz aphelionz changed the title Combo boxes labels not read in Data tab Combo boxes labels not read in Selected Layer Display tab Nov 11, 2018
@aphelionz aphelionz changed the title Combo boxes labels not read in Selected Layer Display tab [Accessibility] Combo boxes labels not read in Selected Layer Display tab Nov 11, 2018
@PhilippBaranovskiy PhilippBaranovskiy self-assigned this Mar 6, 2019
@PhilippBaranovskiy
Copy link
Contributor

The good point is here to discuss whether it should announce the name of the focused color (in the palette popover) as well as the name of a chosen color.
Should it announce the name of the color rather than the HEX color code?

Example: the user is focusing on the "Fill" section, next tabs to the color icon. Before activating that, (s)he should know what the current color is set already.

@timroes @aphelionz

@rayafratkina
Copy link
Contributor

We decided that standard colors will read: Kibana Teal, Kibana Yellow, Kibana Pink, Kibana Blue, Kibana Green. The saturation level will be read out as 1, 2, 3, 4. So the standard colors will be announced as "Kibana Yellow 3" or "Kibana Green 1".
Is user enters a custom color, it should be read as a hex code.

@timductive timductive added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. enhancement New value added to drive a business result and removed discuss labels Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants