-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uiSettings override needs validation #25526
Comments
marius-dr
added
bug
Fixes for quality problems that affect the customer experience
:Management
labels
Nov 12, 2018
Pinging @elastic/kibana-management |
timroes
added
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
and removed
:Management DO NOT USE
labels
Nov 27, 2018
lukeelmers
added
:AppArch
and removed
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
labels
Mar 27, 2019
@marius-dr any idea if this issue is still valid or should we close it? |
ppisljar
added
the
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
label
Mar 9, 2020
Pinging @elastic/kibana-platform (Team:Platform) |
ppisljar
removed
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
Team:AppArch
labels
Mar 9, 2020
requires #46717 |
closed in #59694 overrides are validated during |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 6.5.0
Original install method (e.g. download page, yum, from source, etc.): BC6
Describe the bug:
Right now there seems to be minimal validation for the field values set in the kibana.yml for the overrides.
For example for the
dateFormat:dow
if the string value is something that doesn't exist in the list, it will go to the default value.But if you use a string for numeric fields ( for example
"context:defaultSize": "Ten"
), it won't reset to the default and it will try to use this value and throw an TypeError when the UI tries to use that value (in this example, when you click the "View Surrounding Documents" in Discover)Steps to reproduce:
Errors in browser console (if relevant):
We should have validation for the values and maybe also log a WARNING level message in the Kibana log if the validation fails. We currently do this for the other settings that we have in kibana.yml ( although I agree it might not be the exact same case as most of them are server settings)
cc @spalger
The text was updated successfully, but these errors were encountered: