Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-couple panel action logic from UI #27996

Closed
stacey-gammon opened this issue Jan 3, 2019 · 3 comments
Closed

De-couple panel action logic from UI #27996

stacey-gammon opened this issue Jan 3, 2019 · 3 comments
Labels
discuss Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Meta stale Used to mark issues that were closed for being stale

Comments

@stacey-gammon
Copy link
Contributor

We want actions to be available for any Embeddable, but we don't want to force the embeddable object to come with the chrome that it does in dashboard panels. Think of how Canvas works - actions show up in a right column, not a context menu pop up. If we use Embeddables inside Canvas, we want any available actions to also be exposed inside Canvas - and that means decoupling it from the UI so any container can decide how to expose those actions (either via a context menu, or via some other mechanism).

So we should have both a pluggable actions registry, and keep the panel actions registry separate. At which point, it becomes an interesting question... do we need a panel actions registry at all, or do we dynamically create the panel actions menu from the actions, simple mapping something like menuItem.onClick to action.execute? And menuItem.isVisible to action.supports(Embeddable). We'd have to think about how isVisible and isDisabled work, especially since there is a use case for not knowing whether something will support a given embeddable at any given time. Maybe we need another function like action.canExecute(Embeddable) to determine enabled vs disabled state.

@stacey-gammon stacey-gammon added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@stacey-gammon stacey-gammon added :AppArch Feature:Embedding Embedding content via iFrame and removed Feature:Embedding Embedding content via iFrame labels Jan 3, 2019
@joelgriffith
Copy link
Contributor

Related: #26476

@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2019
@ppisljar ppisljar added Feature:Embedding Embedding content via iFrame stale Used to mark issues that were closed for being stale impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels May 4, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:needs-research This issue requires some research before it can be worked on or estimated labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 9, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Meta stale Used to mark issues that were closed for being stale
Projects
None yet
Development

No branches or pull requests

6 participants