-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas does not use Kibana number formatting locale #28007
Comments
Pinging @elastic/kibana-canvas |
@SpeechlessWick Can you add an example of where you're seeing this number format in Canvas? A screenshot and the expression on your element would be great. |
Thanks for filing @SpeechlessWick! Some additional comments here. Today, Kibana allows you to define Space specific values for formatting of dates and numbers. This will be the default styling used for visualizations, discover, etc. Ideally, all other applications would be using these settings too, Canvas included. Some examples below: If an admin or user has taken the time to adjust these settings, I could understand the frustration when loading these numbers or dates in Canvas and seeing different formats. As @cqliu1 suggested, would you mind sharing the expression so we can duplicate? I haven't seen that format shown by default. |
@SpeechlessWick as per the docs Canvas (and Kibana) are using a forked version of numeral.js. I would think a format like |
Currently, there's no support for changing locales, and it doesn't seem like you can feed in a format to change the delimiter from |
@cqliu1 Do you believe there is a way to accomplish this for the time being? |
@SpeechlessWick It is not currently possible in Canvas. We would need to add locale support to our |
Another customer has hit this issue. They want to format their numbers according to a custom locale, but we don't support it yet. |
@alexfrancoeur @cqliu1 So it would be great that Canvas honors this advanced setting, like Discover/Visualize/Dashboard already does. |
I have the same problem. |
Me too, same problem, in Canvas it doesn't work when setting the Locale=French, show always with english number format |
Thank you for your contribution! We are grooming our backlog to narrow in on items that we have prioritized. If our priorities change, we can reopen. |
Describe the feature:
Canvas should adhere to Kibana formatting settings. Currently Canvas number formatting is dictated by
numeral.js
, which defaults to a period (.) for the decimal separator and a comma (,) for the digit separator. This is not the default Kibana behavior, and can cause frustration for customers.Describe a specific use case for the feature:
Canvas by default should adhere to the default formatting defined in Kibana which as an example would show the following:
1.234.567,89
. Canvas currently shows the following by default:1,234,567.89
.@alexfrancoeur feel free to add any thoughts and/or opinions on this request.
The text was updated successfully, but these errors were encountered: