Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression Language Test Plan (Short Term) #30279

Closed
12 tasks
stacey-gammon opened this issue Feb 6, 2019 · 2 comments
Closed
12 tasks

Expression Language Test Plan (Short Term) #30279

stacey-gammon opened this issue Feb 6, 2019 · 2 comments

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Feb 6, 2019

Goal

Be confident that the expression language is stable enough to release into the wild, on top of a GA canvas, and the current visualizations.

Target: Have a plan ready within 2 - 4 weeks

Automation Plan

Track test completion times in build-stats (https://github.com/elastic/infra/issues/9270)

Doing this will allow us to view average test run times and how they change over time. Averaging them together will hopefully smooth out anomalies coming from network issues, etc. In general, it should help us recognize points in time where changes caused a performance hit.

This route won't help overall though with judging the timing with toggle on and toggle off, since the toggle will be off on master.

I'm (@stacey-gammon) currently investigating this.

To at least get the test completion times locally, this PR does the trick: https://github.com/elastic/kibana/pull/30285/files

Add tests for more complicated expressions

If we can set up the former so we can see the time over a given run, the next step would be to add some tests that include more interesting expressions that are specifically designed. For instance:

serverFn | commonFn | serverFn | commonFn

We could also create some test expressions that do something like send back a payload of data of the size requested.

This isn't necessary as part of the test plan. We can do this manually as well. It just might not be that much more effort to build it as a test and then it makes it much easier to write up steps that everyone can try out on their own environments.

We should explore #22139 too but I don't know if there is enough time to do this within 2 - 4 weeks.

Manual Test Plan

Copied over from the Plugin Review Issue Template

  • Elasticsearch and Kibana Configuration tests
    • Multiple Kibana instances pointing to the same index
    • Multiple Kibana instances pointing to different indexes
  • Test with cross cluster search or cross cluster replication?
  • Performance and load tests
    • Many fields
    • Many indexes
    • Lots of data
    • Lots of saved objects
    • Large saved objects
    • Browser left running overnight (endurance tests)
  • Tested behind a reverse proxy

Going to try to go through some of the performance benchmarks here: https://docs.google.com/spreadsheets/d/1kPTqGKn1thG0TcZl5-BYhDN6Em40Ac7wrRosZDU0w1o/edit#gid=1802315937
-- nothing is set up yet though.

@stacey-gammon stacey-gammon added Team:Visualizations Visualization editors, elastic-charts and infrastructure :AppArch labels Feb 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2019
@ppisljar
Copy link
Member

ppisljar commented May 4, 2021

closing this as most of the above points have been done and we have separate issues tracking any remaining work

@ppisljar ppisljar closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants