-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate schema-less specs in Vega #30951
Comments
I'm not planning to self-assign this item first, or in the near future, but still have some clarifying questions about the goals, also to learn a bit about Vega related migrations in general:
Also, as we're already on Vega 4, if the user makes a new thing which has no specs, is it assumed to be Vega 4, and if so, is it part of this issue to change it to work with the assumption that the given spec is Vega 3 (ie. add a version spec for Vega 3 behind the scenes)? cc @flash1293 |
I'm not 100% sure about all edge cases, but if the schema specifies a version, vega will behave like this version, right? So we could simplify this and do this change also in a minor version - migrate all current vega visualizations without schema to use the version 3 schema and don't render anymore if a user omits the schema. All currently saved visualizations will continue to work and for new ones the user will pick a version from the start. |
* Deprecate schema-less specs in Vega Closes #30951 * update an error Message * update tests * update error message * Update vega_parser.ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Deprecate schema-less specs in Vega Closes elastic#30951 * update an error Message * update tests * update error message * Update vega_parser.ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Deprecate schema-less specs in Vega Closes #30951 * update an error Message * update tests * update error message * Update vega_parser.ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Follow up from #30628 (comment)
We should deprecate Vega specs, without a schema defined (currently we assume 3.0 in that case), in early 7.x, and remove the functionality in 8.0. Since updating the default schema for schema-less specs when we upgrade Vega, would potentially result in breaking existing visualizations, meaning we are now basically stuck to 3.0 for schema-less specifications.
That's why I think we should get rid of schema-less specs completely and enforce the user to specify their Vega spec version explicitly.
The text was updated successfully, but these errors were encountered: