Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Clarify that the 'Time filter' element applies to the entire workpad #31329

Closed
ryankeairns opened this issue Feb 15, 2019 · 6 comments
Closed
Labels
chore Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ryankeairns
Copy link
Contributor

Describe the feature:
Make it clear to users that the Time filter element applies to the entire workpad.

Describe a specific use case for the feature:
This question has come up many times to the Canvas team as users expect this element to apply only to the page it is placed on. Short of changing how this works, a simple stopgap would be to simply state this fact up front. More specifically, add some extra text to the element description and/or put a note in the docs to the effect of "...applies to the entire workpad...".

cc: @cqliu1 @alexfrancoeur

@ryankeairns ryankeairns added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@alexfrancoeur
Copy link

@ryankeairns I'm good with adding more descriptive text for this element. I think we could do so in a few different areas. @gchaps what do you think the best way to phrase this might be?

image

image

Additionally, what are the thoughts on renaming the element to "Workpad timefilter" or something along those lines. Thinking ahead, I'd like to see a timefilter element that would apply to one or multiple elements. So it's possible we could provide an ootb experience for a "Workpad timefilter" and an "Element timefilter" in the future.

@gchaps
Copy link
Contributor

gchaps commented Feb 19, 2019

+1 for adding Workpad to the title. I edited the description so that it is consistent with the descriptions for other elements:

Workpad time filter

A calendar for selecting dates and times for a workpad

@cqliu1 cqliu1 added chore loe:small Small Level of Effort labels Mar 15, 2019
@w33ble
Copy link
Contributor

w33ble commented May 29, 2019

Time filter element applies to the entire workpad

That's true by default, but with the addition of filter grouping, that's not always true now. Also, this applies to any filters, not just the time picker. Dropdown and the hidden advanced filter work the same way. All filters are global (at least by default).

@pedrosk
Copy link

pedrosk commented Jun 4, 2019

+1

@timductive
Copy link
Member

Closing this in favor of the Filters Meta issue #50985 since filters are now more complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Canvas loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

9 participants