Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for getSchema pipeline utility #33196

Closed
lukeelmers opened this issue Mar 13, 2019 · 2 comments
Closed

Add unit tests for getSchema pipeline utility #33196

lukeelmers opened this issue Mar 13, 2019 · 2 comments
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Mar 13, 2019 •
edited by ppisljar
Loading

Need to get some unit tests in place for getSchema in the pipeline utilities.

So far our existing unit tests (e.g. buildPipeline) have been very useful and caught a bunch of bugs. Lately we've seen more issues pop up with getSchema, which is pretty large and has a lot going on, so it seems it would be a logical next priority in terms of test coverage

parent issue #51247
@lukeelmers lukeelmers added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Visualizations Visualization editors, elastic-charts and infrastructure :AppArch labels Mar 13, 2019
@lukeelmers lukeelmers self-assigned this Mar 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes mentioned this issue Mar 13, 2019
Closed
58 tasks
@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2019
@lukeelmers lukeelmers mentioned this issue Mar 29, 2019
Merged
@streamich streamich mentioned this issue Nov 22, 2019
Closed
4 tasks
@lukeelmers lukeelmers removed their assignment Dec 2, 2019
@lukeelmers
Copy link
Member Author

closing as this work can be covered in #51246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timroes @lukeelmers @elasticmachine