Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fix elements' default colors in dark mode #33279

Closed
cqliu1 opened this issue Mar 15, 2019 · 4 comments
Closed

[Canvas] Fix elements' default colors in dark mode #33279

cqliu1 opened this issue Mar 15, 2019 · 4 comments
Assignees
@clintandrewhall
Labels
design discuss enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG AA

Comments

@cqliu1
Copy link
Contributor

cqliu1 commented Mar 15, 2019 •
edited by myasonik
Loading

Kibana version:
7.0.0

Describe the bug:
The time filter and debug element default to a black background. Is this expected?

The datatable and markdown elements have a light grey font color, and the text isn't very visible on the white background.

Should the workpad default to a dark background instead of white when Kibana is in dark mode?

Screenshots (if relevant):
Screen Shot 2019-03-14 at 5 15 13 PM

Relevant WCAG Criteria: 1.4.3 Contrast (Minimum) - Level AA
@monfera monfera added discuss Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@bhavyarm bhavyarm added the bug Fixes for quality problems that affect the customer experience label Jun 10, 2019
@cqliu1 cqliu1 added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort and removed discuss labels Jun 10, 2019
@ryankeairns ryankeairns mentioned this issue Jul 12, 2019
Closed
44 tasks
@shaunmcgough shaunmcgough mentioned this issue Dec 17, 2019
Closed
25 tasks
@clintandrewhall clintandrewhall self-assigned this Apr 5, 2021
@clintandrewhall clintandrewhall added enhancement New value added to drive a business result discuss and removed bug Fixes for quality problems that affect the customer experience labels Apr 5, 2021
@clintandrewhall
Copy link
Contributor

We should have a discussion about workpad light/dark modes and themes. EUI Variables and themes will play a role. This is an enhancement.

@cqliu1 cqliu1 mentioned this issue Feb 23, 2023
Closed
@cqliu1
Copy link
Contributor Author

cqliu1 commented Apr 6, 2023

Closing because you can configure each element's colors to override the defaults and fit a dark themed workpad.

@cqliu1 cqliu1 closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clintandrewhall clintandrewhall

Labels
design discuss enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG AA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@clintandrewhall @ryankeairns @timroes @monfera @cqliu1 @myasonik @bhavyarm @elasticmachine