Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable graph saved objects to be import / exportable. #34997

Closed
mikecote opened this issue Apr 12, 2019 · 4 comments · Fixed by #85295
Closed

Enable graph saved objects to be import / exportable. #34997

mikecote opened this issue Apr 12, 2019 · 4 comments · Fixed by #85295
Labels
Feature:Graph Graph application feature Feature:Saved Objects Project:RemoveLegacyMultitenancy Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mikecote
Copy link
Contributor

Once #34989 and #34862 are completed, graph saved objects can be enabled for import / export. Follow #34896 or upcoming docs to enable the feature.

@mikecote mikecote added Feature:Graph Graph application feature Feature:Saved Objects Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@flash1293
Copy link
Contributor

After syncing with @rudolf there is a workaround to solve it in a slightly hacky way just for Graph.

The thing to migrate is changing index patterns referenced by name to index patterns referenced by id.

Instead of migrating using the migration system, the Graph app inspects the saved objects if a user opens a workspace. If it is using the name reference, it will try to find the matching index pattern and fix the index pattern reference in memory. If the user saves the workspace, the updated version will get persisted.

There are a few edge cases (e.g. what if there is no matching index pattern), but the Graph app is planned to handle changes between index patterns anyway, so the logic to handle that will be available.

@shaunmcgough
Copy link

Joe are you comfortable with this approach? I would also consider the way Canvas handles this - as a JSON to import / export.

@flash1293
Copy link
Contributor

@shaunmcgough I think it's the right thing here to integrate with the migration/import/export system as much as possible, gives the user a single place to manage these things.

Canvas also does this:
Screenshot 2019-09-09 at 09 26 45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature Feature:Saved Objects Project:RemoveLegacyMultitenancy Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants