-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable graph saved objects to be import / exportable. #34997
Comments
Pinging @elastic/kibana-app |
After syncing with @rudolf there is a workaround to solve it in a slightly hacky way just for Graph. The thing to migrate is changing index patterns referenced by name to index patterns referenced by id. Instead of migrating using the migration system, the Graph app inspects the saved objects if a user opens a workspace. If it is using the name reference, it will try to find the matching index pattern and fix the index pattern reference in memory. If the user saves the workspace, the updated version will get persisted. There are a few edge cases (e.g. what if there is no matching index pattern), but the Graph app is planned to handle changes between index patterns anyway, so the logic to handle that will be available. |
Joe are you comfortable with this approach? I would also consider the way Canvas handles this - as a JSON to import / export. |
@shaunmcgough I think it's the right thing here to integrate with the migration/import/export system as much as possible, gives the user a single place to manage these things. |
Once #34989 and #34862 are completed, graph saved objects can be enabled for import / export. Follow #34896 or upcoming docs to enable the feature.
The text was updated successfully, but these errors were encountered: